Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix layer norm documentation #13732

Merged

Conversation

eric-haibin-lin
Copy link
Member

Description

The documentation of nn.LayerNorm is incorrect in terms of how eps is used. Update it so that it's now consistent with ndarray.LayerNorm.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Copy link
Member

@sxjscience sxjscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@eric-haibin-lin
Copy link
Member Author

@marcoabreu @larroy do you know why ci/jenkins/mxnet-validation/edge is taking forever for this simple change?

Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the mshadow change intentional?

@eric-haibin-lin
Copy link
Member Author

@szha No that's an accident when I tried to trigger CI. I'll force push again

@sandeep-krishnamurthy sandeep-krishnamurthy merged commit 8132a5b into apache:master Dec 29, 2018
rondogency pushed a commit to rondogency/incubator-mxnet that referenced this pull request Jan 9, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@eric-haibin-lin eric-haibin-lin deleted the layer-norm-doc-fix branch December 12, 2019 00:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants