Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

ONNX import: Hardmax #13717

Merged
merged 3 commits into from
Dec 29, 2018
Merged

Conversation

vandanavk
Copy link
Contributor

@vandanavk vandanavk commented Dec 21, 2018

Description

Import ONNX's Hardmax

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • import using existing operators
  • add tests

Comments

@vandanavk vandanavk requested a review from szha as a code owner December 21, 2018 23:28
@vandanavk
Copy link
Contributor Author

@mxnet-label-bot add [ONNX, pr-awaiting-review]

@marcoabreu marcoabreu added ONNX pr-awaiting-review PR is waiting for code review labels Dec 21, 2018
Copy link
Contributor

@sandeep-krishnamurthy sandeep-krishnamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
LGTM.

@sandeep-krishnamurthy
Copy link
Contributor

@vandanavk - Can you please rebase and we are ready to go here

@sandeep-krishnamurthy sandeep-krishnamurthy merged commit 991bf3b into apache:master Dec 29, 2018
rondogency pushed a commit to rondogency/incubator-mxnet that referenced this pull request Jan 9, 2019
* ONNX import: Hardmax

* Fix lint errors

* add github link for issue with reshape
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* ONNX import: Hardmax

* Fix lint errors

* add github link for issue with reshape
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ONNX pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants