Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix omp bug in multibox_detection to avoid accuracy variance in ssd #13622

Merged
merged 2 commits into from
Dec 17, 2018

Conversation

xinyu-intel
Copy link
Contributor

@xinyu-intel xinyu-intel commented Dec 12, 2018

Description

This PR is to fix omp bug in multibox_detection to avoid accuracy variance of SSD topology.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • delete pragma omp in multibox_detection.cc

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@pengzhao-intel @TaoLv

@xinyu-intel xinyu-intel changed the title [WIP]Fix SSD accuracy variance Fix SSD accuracy variance Dec 13, 2018
@xinyu-intel xinyu-intel changed the title Fix SSD accuracy variance Fix omp bug in multibox_detection to avoid accuracy variance in ssd Dec 13, 2018
@pengzhao-intel
Copy link
Contributor

@apeforest @yuxihu could you help take a review?

@roywei
Copy link
Member

roywei commented Dec 14, 2018

@mxnet-label-bot add[Backend, pr-awaiting-review]

@marcoabreu marcoabreu added Backend Issues related to the backend of MXNet pr-awaiting-review PR is waiting for code review labels Dec 14, 2018
@TaoLv
Copy link
Member

TaoLv commented Dec 15, 2018

@xinyu-intel please also paste the performance change of SSD model. If it's negligible, I think this PR is good to go. Thank you.

@xinyu-intel
Copy link
Contributor Author

P40:

INFO:root:Finished inference with 2240 images
INFO:root:Finished with 98.885987 images per second
aeroplane: 0.9057971014492755
bicycle: 0.8785621389155159
bird: 0.8363940601702841
boat: 0.815100739467124
bottle: 0.5618223281277894
bus: 0.8598314060584938
car: 0.8784382442430079
cat: 0.9079754601226996
chair: 0.7933105641842106
cow: 0.8931324110671939
diningtable: 0.7848938200906703
dog: 0.9082568807339451
horse: 0.9072727272727275
motorbike: 0.8930925944284724
person: 0.8115480659727458
pottedplant: 0.6432418831953183
sheep: 0.768227393378024
sofa: 0.901451489686784
train: 0.9090909090909093
tvmonitor: 0.8745790605051967
mAP: 0.8366009639080195

Skylake Before fix:

INFO:root:Finished inference with 2240 images
INFO:root:Finished with 35.336766 images per second
aeroplane: 0.9064366290643664
bicycle: 0.8764411277427806
bird: 0.8329125417396593
boat: 0.8169674072031251
bottle: 0.5641319814350945
bus: 0.8518312996387211
car: 0.8786306281515983
cat: 0.9079754601226996
chair: 0.7892002458528512
cow: 0.8938258442549063
diningtable: 0.7858787878787877
dog: 0.9082568807339451
horse: 0.9072727272727275
motorbike: 0.8940118558899026
person: 0.8054880205849446
pottedplant: 0.644885725730972
sheep: 0.7581358014045285
sofa: 0.901451489686784
train: 0.9090909090909093
tvmonitor: 0.8752740177218932
mAP: 0.8354049690600599

Skylake After fix

INFO:root:Finished inference with 2240 images
INFO:root:Finished with 35.335017 images per second
aeroplane: 0.9057971014492755
bicycle: 0.8785621389155159
bird: 0.8363940601702841
boat: 0.815100739467124
bottle: 0.5618223281277894
bus: 0.8598314060584938
car: 0.8784382442430079
cat: 0.9079754601226996
chair: 0.7933105641842106
cow: 0.8931324110671939
diningtable: 0.7848938200906703
dog: 0.9082568807339451
horse: 0.9072727272727275
motorbike: 0.8930925944284724
person: 0.8115480659727458
pottedplant: 0.6432418831953183
sheep: 0.768227393378024
sofa: 0.901451489686784
train: 0.9090909090909093
tvmonitor: 0.8745790605051967
mAP: 0.8366009639080195

@TaoLv
Copy link
Member

TaoLv commented Dec 17, 2018

Thank you for the fix.

@TaoLv TaoLv merged commit 655f1c6 into apache:master Dec 17, 2018
KellenSunderland added a commit that referenced this pull request Dec 17, 2018
aaronmarkham pushed a commit that referenced this pull request Dec 18, 2018
* Revert "remove omp which can cause ssd accuracy variance (#13622)"

This reverts commit 655f1c6.

* Revert "Fix Jetson compilation (#13532)"

This reverts commit 48e25c4.
mseth10 pushed a commit to mseth10/incubator-mxnet that referenced this pull request Dec 18, 2018
mseth10 pushed a commit to mseth10/incubator-mxnet that referenced this pull request Dec 18, 2018
* Revert "remove omp which can cause ssd accuracy variance (apache#13622)"

This reverts commit 655f1c6.

* Revert "Fix Jetson compilation (apache#13532)"

This reverts commit 48e25c4.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Backend Issues related to the backend of MXNet pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants