This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-1231] Allow not using Some in the Scala operators #13619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanking520
force-pushed
the
allowSome
branch
from
51f1c81
to
1be5a5e
Compare
|
@lanking520 Thanks for the contribution! any documentation on how to use SomeConversion? |
zachgk
suggested changes
Dec 12, 2018
Wei-1
reviewed
Dec 12, 2018
scala-package/macros/src/main/scala/org/apache/mxnet/utils/CToScalaUtils.scala
Outdated
Show resolved
Hide resolved
lanking520
force-pushed
the
allowSome
branch
3 times, most recently
from
6da10d4
to
01716c3
Compare
yzhliu
reviewed
Dec 20, 2018
scala-package/core/src/main/scala/org/apache/mxnet/util/SomeConversion.scala
Outdated
Show resolved
Hide resolved
lanking520
force-pushed
the
allowSome
branch
from
c495e32
to
6db5068
Compare
|
@lanking520 Can you retrigger CI? |
rondogency
pushed a commit
to rondogency/incubator-mxnet
that referenced
this pull request
Jan 9, 2019
* add initial commit * update image classifier as well * create Util class make Some conversion * add test changes * adress Comments * fix the spacing problem * fix generator base * change name to Option
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* add initial commit * update image classifier as well * create Util class make Some conversion * add test changes * adress Comments * fix the spacing problem * fix generator base * change name to Option
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a new Util called SomeConversion. Import that would help to reduce all Some usages.
@nswamy @yzhliu @andrewfayres @zachgk @piyushghai
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.