This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
fallback to dense version for grad(reshape), grad(expand_dims) #13599
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current
reshape
uses_backward_copy
to do gradient calculation.But
_backward_copy
sparse calculation requires same shapes of input and output - which is fair since sparsity is bind to # of rows and cols.And though
reshape
itself does not have sparse version, we can easily construct a network, in which its backward input and output are sparse - see test case.Thus we need to provide a fallback version for
reshape
backward computation, so asexpand_dims
.@eric-haibin-lin @zheng-da
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.