Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-1195] Cleanup Scala README file #13582

Merged
merged 7 commits into from
Dec 15, 2018
Merged

Conversation

piyushghai
Copy link
Contributor

Description

The scala-package/README file is outdated and contains some stale information.
This PR aims to clean up the Scala README and also adds new information with regards to the inference APIs for Scala/Java as well as the new Memory Management system.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@lanking520 @andrewfayres @zachgk

@piyushghai
Copy link
Contributor Author

piyushghai commented Dec 7, 2018

@mxnet-label-bot add [Scala, Java, doc]

Copy link
Member

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcoabreu marcoabreu added Java Label to identify Java API component Scala Doc labels Dec 7, 2018
scala-package/README.md Outdated Show resolved Hide resolved
scala-package/README.md Outdated Show resolved Hide resolved
scala-package/README.md Outdated Show resolved Hide resolved
Copy link
Member

@nswamy nswamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the documentation, I have a few comments for consideration.

scala-package/README.md Show resolved Hide resolved
scala-package/README.md Outdated Show resolved Hide resolved
scala-package/README.md Outdated Show resolved Hide resolved
scala-package/README.md Show resolved Hide resolved
Copy link
Member

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanking520 lanking520 merged commit a024a90 into apache:master Dec 15, 2018
mseth10 pushed a commit to mseth10/incubator-mxnet that referenced this pull request Dec 18, 2018
* Updated the Scala-Readme with upto-date information

* Updated the header

* Removed redundant build status

* Minor formatting changes

* Addressed the PR feedback

* Added section on Scala training APIs

* Removed mention of deprecated Model API
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Doc Java Label to identify Java API component Scala
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants