Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Update CODEOWNERS, add Pedro Larroy. #13579

Merged
merged 1 commit into from
Dec 18, 2018
Merged

Conversation

larroy
Copy link
Contributor

@larroy larroy commented Dec 7, 2018

Description

Added Pedro Larroy to CODEOWNERS

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@larroy
Copy link
Contributor Author

larroy commented Dec 7, 2018

@nswamy

@marcoabreu
Copy link
Contributor

This won't work since you are not a committer

@larroy
Copy link
Contributor Author

larroy commented Dec 8, 2018

Naveen told me something else in slack.

@nswamy nswamy added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-review PR is waiting for code review labels Dec 8, 2018
@nswamy
Copy link
Member

nswamy commented Dec 18, 2018

what marco is saying is you might still not get notifications if you are not a committer. You can use https://github.com/gitwatch/gitwatch to get notifications if don't get notifications.

@nswamy nswamy merged commit 5e46db4 into apache:master Dec 18, 2018
mseth10 pushed a commit to mseth10/incubator-mxnet that referenced this pull request Dec 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants