Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add pixelshuffle layers #13571

Merged
merged 7 commits into from
Feb 14, 2019
Merged

Add pixelshuffle layers #13571

merged 7 commits into from
Feb 14, 2019

Conversation

kohr-h
Copy link
Contributor

@kohr-h kohr-h commented Dec 7, 2018 •
edited
Loading

Description

Pixel shuffle layers, as discussed in #13548

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Closes #13548

@kohr-h kohr-h requested a review from szha as a code owner December 7, 2018 10:13
@nswamy nswamy added Operator pr-awaiting-review PR is waiting for code review and removed pr-awaiting-review PR is waiting for code review labels Dec 8, 2018
@ThomasDelteil
Copy link
Contributor

@kohr-h, thanks for the contribution! Can you add tests for your new layers? Also can you add a bit more documentation and reference the original paper, thanks!

@Roshrini
Copy link
Member

@mxnet-label-bot Update [Operator, pr-awaiting-response]

@marcoabreu marcoabreu added the pr-awaiting-response PR is reviewed and waiting for contributor to respond label Dec 19, 2018
@kohr-h
Copy link
Contributor Author

kohr-h commented Dec 23, 2018

Axis swapping issue is fixed now. The 2D version now does the same as the PyTorch implementation. I'll add some more documentation.

@kohr-h
Copy link
Contributor Author

kohr-h commented Dec 25, 2018

Just updated the superresolution example with the new layer, seems to work fine. The old download link wasn't working any more, so I switched to a GitHub mirror of the newer version of the dataset.

@kohr-h
Copy link
Contributor Author

kohr-h commented Dec 25, 2018

Ready for review now.

@Roshrini
Copy link
Member

Roshrini commented Jan 8, 2019

@apeforest @zhreshold @eric-haibin-lin Can you please help in reviewing this PR? Thanks
@mxnet-label-bot Update [pr-awaiting-review, Operator]

@marcoabreu marcoabreu added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-response PR is reviewed and waiting for contributor to respond labels Jan 8, 2019
stu1130
stu1130 approved these changes Jan 16, 2019
View reviewed changes
Copy link
Contributor

@stu1130 stu1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@sandeep-krishnamurthy could you review it? Thanks

@sandeep-krishnamurthy
Copy link
Contributor

@ThomasDelteil - Can you please help review this PR?

@vandanavk
Copy link
Contributor

LGTM.

@zhreshold @Mut1nyJD for review.

@kohr-h if merging this PR would fix #13548, please add "Fixes #13548" in the PR description. this will automatically close the issue when the PR is merged.

@vandanavk
Copy link
Contributor

@mxnet-label-bot add [Gluon]

@kohr-h
Copy link
Contributor Author

kohr-h commented Feb 8, 2019

@vandanavk I added the corresponding text.

@szha szha requested a review from zhreshold February 8, 2019 21:18
zhreshold
zhreshold approved these changes Feb 8, 2019
View reviewed changes
Copy link
Member

@zhreshold zhreshold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which looks good to me, awesome job

@ankkhedia
Copy link
Contributor

@ThomasDelteil Could you please help review/merge this PR?

@ThomasDelteil ThomasDelteil merged commit de5cda2 into apache:master Feb 14, 2019
@kohr-h
Copy link
Contributor Author

kohr-h commented Feb 15, 2019

👍

@kohr-h kohr-h deleted the pixelshuffle branch February 15, 2019 10:20
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
@kohr-h @stephenrawls
Add pixelshuffle layers (apache#13571)
3fe2a72 
* Add pixelshuffle layers, closes apache#13548

* Remove fmt comments

* Use explicit class in super()

* Add axis swapping to pixel shuffling, add tests

* Add documentation to pixel shuffle layers

* Use pixelshuffle layer and fix download in superres example

* Add pixelshuffle layers to API doc page
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Feb 19, 2019
@kohr-h
Add pixelshuffle layers (apache#13571)
ed65b24 
* Add pixelshuffle layers, closes apache#13548

* Remove fmt comments

* Use explicit class in super()

* Add axis swapping to pixel shuffling, add tests

* Add documentation to pixel shuffle layers

* Use pixelshuffle layer and fix download in superres example

* Add pixelshuffle layers to API doc page
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Mar 4, 2019
@kohr-h @drivanov
Add pixelshuffle layers (apache#13571)
e358be0 
* Add pixelshuffle layers, closes apache#13548

* Remove fmt comments

* Use explicit class in super()

* Add axis swapping to pixel shuffling, add tests

* Add documentation to pixel shuffle layers

* Use pixelshuffle layer and fix download in superres example

* Add pixelshuffle layers to API doc page
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
@kohr-h @vdantu
Add pixelshuffle layers (apache#13571)
b4d0f3f 
* Add pixelshuffle layers, closes apache#13548

* Remove fmt comments

* Use explicit class in super()

* Add axis swapping to pixel shuffling, add tests

* Add documentation to pixel shuffle layers

* Use pixelshuffle layer and fix download in superres example

* Add pixelshuffle layers to API doc page
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@kohr-h
Add pixelshuffle layers (apache#13571)
d761b14 
* Add pixelshuffle layers, closes apache#13548

* Remove fmt comments

* Use explicit class in super()

* Add axis swapping to pixel shuffling, add tests

* Add documentation to pixel shuffle layers

* Use pixelshuffle layer and fix download in superres example

* Add pixelshuffle layers to API doc page
@Ldpe2G Ldpe2G mentioned this pull request Nov 10, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ThomasDelteil ThomasDelteil ThomasDelteil left review comments

@zhreshold zhreshold zhreshold approved these changes

@stu1130 stu1130 stu1130 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
Gluon Operator pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request / Proposal] Pixel shuffle layer
10 participants
@kohr-h @ThomasDelteil @Roshrini @sandeep-krishnamurthy @vandanavk @ankkhedia @zhreshold @stu1130 @nswamy @marcoabreu