Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-1253] fix control_flow_op #13555

Merged
merged 3 commits into from
Dec 11, 2018

Conversation

apeforest
Copy link
Contributor

Description

Support large array in control_flow_ops

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • test_large_array.py:test_where()

@apeforest
Copy link
Contributor Author

Copy link
Member

@yuxihu yuxihu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/operator/tensor/control_flow_op.h Outdated Show resolved Hide resolved
src/operator/tensor/control_flow_op.h Outdated Show resolved Hide resolved
Copy link
Contributor

@sandeep-krishnamurthy sandeep-krishnamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@codecov-io
Copy link

Codecov Report

Merging #13555 into master will increase coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13555      +/-   ##
==========================================
+ Coverage   82.69%   83.24%   +0.54%     
==========================================
  Files         720      745      +25     
  Lines       79320    83337    +4017     
  Branches     3190     3188       -2     
==========================================
+ Hits        65596    69376    +3780     
- Misses      12863    13102     +239     
+ Partials      861      859       -2
Impacted Files Coverage Δ
src/operator/tensor/control_flow_op.h 96.22% <ø> (ø) ⬆️
src/operator/tensor/dot-inl.cuh 90.38% <0%> (-1.93%) ⬇️
...re-package/src/org/apache/clojure_mxnet/random.clj 100% <0%> (ø) ⬆️
tests/cpp/kvstore/gpu_topology_test.cc 97.28% <0%> (ø)
tests/cpp/operator/batchnorm_test.cc 87.07% <0%> (ø)
tests/cpp/operator/runner/core_op_runner_test.cc 95.86% <0%> (ø)
tests/cpp/operator/fully_conn_perf.cc 94.73% <0%> (ø)
tests/cpp/include/test_core_op.h 95.23% <0%> (ø)
tests/cpp/operator/tune/operator_tune_test.cc 92.15% <0%> (ø)
tests/cpp/misc/base.cc 100% <0%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bbac82...08f4977. Read the comment docs.

@nswamy nswamy added pr-awaiting-review PR is waiting for code review Operator pr-awaiting-response PR is reviewed and waiting for contributor to respond and removed pr-awaiting-review PR is waiting for code review labels Dec 7, 2018
@apeforest
Copy link
Contributor Author

@mxnet-label-bot Update [pr-awaiting-merge]

@marcoabreu marcoabreu added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed Operator pr-awaiting-response PR is reviewed and waiting for contributor to respond labels Dec 10, 2018
@apeforest
Copy link
Contributor Author

@mxnet-label-bot Update [pr-awaiting-merge, Operator]

Copy link
Contributor

@sandeep-krishnamurthy sandeep-krishnamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@sandeep-krishnamurthy
Copy link
Contributor

@TaoLv - I see your comments are addressed. This is good to merge, I will wait for your confirmation.

@anirudh2290
Copy link
Member

Can you add the remaining test for scatter_nd or is it planned for a different PR ?

@apeforest
Copy link
Contributor Author

@anirudh2290 It's planned for a different PR as this PR does not directly fix scatter_nd

@TaoLv
Copy link
Member

TaoLv commented Dec 11, 2018

Seems all comments are addressed. Now merging.

@TaoLv TaoLv merged commit 46a2990 into apache:master Dec 11, 2018
zhaoyao73 added a commit to zhaoyao73/incubator-mxnet that referenced this pull request Dec 13, 2018
* upstream/master:
  [MXNET-1253] fix control_flow_op (apache#13555)
  Add imresize and copyMakeBorder to mx.image (apache#13357)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Operator pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants