Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Rearrange tests written only for update_on_kvstore = True #13514

Merged
merged 4 commits into from
Dec 22, 2018
Merged

Rearrange tests written only for update_on_kvstore = True #13514

merged 4 commits into from
Dec 22, 2018

Conversation

eric-haibin-lin
Copy link
Member

Description

@ptrendx

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@vandanavk
Copy link
Contributor

@mxnet-label-bot add [KVStore, Test, pr-awaiting-review]

@marcoabreu marcoabreu added KVStore pr-awaiting-review PR is waiting for code review Test labels Dec 3, 2018
roywei
roywei approved these changes Dec 14, 2018
View reviewed changes
Copy link
Member

@roywei roywei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eric-haibin-lin eric-haibin-lin merged commit e8e18c9 into apache:master Dec 22, 2018
rondogency pushed a commit to rondogency/incubator-mxnet that referenced this pull request Jan 9, 2019
@eric-haibin-lin
Rearrange tests written only for update_on_kvstore = True (apache#13514)
89e7064 
* Update test_gluon_trainer.py

* Update test_gluon_trainer.py

* test
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@eric-haibin-lin
Rearrange tests written only for update_on_kvstore = True (apache#13514)
17874b4 
* Update test_gluon_trainer.py

* Update test_gluon_trainer.py

* test
@eric-haibin-lin eric-haibin-lin deleted the fix-test branch September 2, 2019 23:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roywei roywei roywei approved these changes

Assignees
No one assigned
Labels
KVStore pr-awaiting-review PR is waiting for code review Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eric-haibin-lin @vandanavk @roywei @marcoabreu @szha