Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Clojure] Correct the versions in the README so they correspond to the latest maven.org release #13507

Merged
merged 5 commits into from
Dec 13, 2018

Conversation

gigasquid
Copy link
Member

@gigasquid gigasquid commented Dec 1, 2018

Description

During the last big version update, the README for the Clojure package had the incorrect versions put in.

After some conversations with people managing the release updates, it seems like it would be better to have it version independent so that the README would not have to be updated with every release.

Instructions were also added about using the Scala nightly snapshots instead of having to build master.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@gigasquid gigasquid requested a review from nswamy December 3, 2018 22:28
Copy link
Member

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree for now. But will you need to do this again if we release 1.4.0?

@gigasquid
Copy link
Member Author

@lanking520 good point - I think it might be beneficial to change it to more general language so we don't need to update it every release

@gigasquid
Copy link
Member Author

Also going to wait until #13478 is merged first

Copy link
Contributor

@kohr-h kohr-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a few comments, but overall this totally makes sense.

contrib/clojure-package/README.md Outdated Show resolved Hide resolved
contrib/clojure-package/README.md Show resolved Hide resolved
contrib/clojure-package/README.md Outdated Show resolved Hide resolved
contrib/clojure-package/README.md Outdated Show resolved Hide resolved
contrib/clojure-package/README.md Outdated Show resolved Hide resolved
contrib/clojure-package/README.md Outdated Show resolved Hide resolved
contrib/clojure-package/README.md Outdated Show resolved Hide resolved
contrib/clojure-package/README.md Outdated Show resolved Hide resolved
contrib/clojure-package/README.md Outdated Show resolved Hide resolved
contrib/clojure-package/README.md Show resolved Hide resolved
@gigasquid
Copy link
Member Author

gigasquid commented Dec 7, 2018

Thanks so much @kohr-h for your review and comments. Much appreciated 💯 . I will incorporate your feedback shortly.

@gigasquid gigasquid merged commit aca93d8 into apache:master Dec 13, 2018
@gigasquid gigasquid deleted the fix-clojure-version-readme branch December 13, 2018 23:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Clojure pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants