Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Improve CCache handling #13456

Merged
merged 16 commits into from
Dec 14, 2018
Merged
Prev Previous commit
Next Next commit
Modify user permissions
  • Loading branch information
marcoabreu committed Nov 29, 2018
commit 84865cad7f61c6c1a890fdd96113dc99a7913351
5 changes: 5 additions & 0 deletions ci/docker/install/centos7_adduser.sh
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,9 @@ then
mkdir /work/mxnet
mkdir /work/build
chown -R jenkins_slave /work/

# Later on, we have to override the links because underlying build systems ignore our compiler settings. Thus,
# we have to give the process the proper permission to these files. This is hacky, but unfortunately
# there's no better way to do this without patching all our submodules.
chown -R jenkins_slave /usr/local/bin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not clear, even with comment I don't understand why. Why can't we have some other folder added to the PATH?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do, that's why I created /tmp/ccache-redirects. The problem is that in some places (especially submodules), that paths have been hardcoded. That's why we have to do both :(

fi
5 changes: 5 additions & 0 deletions ci/docker/install/ubuntu_adduser.sh
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,9 @@ then
mkdir /work/mxnet
mkdir /work/build
chown -R jenkins_slave /work/

# Later on, we have to override the links because underlying build systems ignore our compiler settings. Thus,
# we have to give the process the proper permission to these files. This is hacky, but unfortunately
# there's no better way to do this without patching all our submodules.
chown -R jenkins_slave /usr/local/bin
fi