This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
onnx softmaxoutput fix #13116
Merged
onnx softmaxoutput fix #13116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vandanavk
approved these changes
Nov 5, 2018
|
@mxnet-label-bot[pr-awaiting-review, ONNX] |
|
@Roshrini can you give more context why this change is needed. The link you provided just says that there is a bug. What is the bug, how was it introduced, and how is this fixing it? @zhreshold for review. |
|
get_inputs(node, kwargs) method which was getting used works on all the inputs whereas for SoftmaxOutput operator we are using single input. So, iterating on all the inputs gave OutOfIndex error. |
|
@zhreshold Can you review/merge this PR? |
|
@mxnet-label-bot update [pr-awaiting-merge] |
marcoabreu
added
pr-awaiting-merge
|
@mxnet-label-bot update [pr-work-in-progress] |
marcoabreu
added
pr-work-in-progress
|
@mxnet-label-bot add [pr-awaiting-testing] |
marcoabreu
added
the
pr-awaiting-testing
zhreshold
suggested changes
Dec 3, 2018
| @@ -681,7 +681,7 @@ def convert_softmax_output(node, **kwargs): | |||
| """Map MXNet's SoftmaxOutput operator attributes to onnx's Softmax operator | |||
| and return the created node. | |||
| """ | |||
| name, _, _ = get_inputs(node, kwargs) | |||
| name = node["name"] | |||
There was a problem hiding this comment.
The change LGTM, can you add a test case to guard this against happening again?
|
@sandeep-krishnamurthy @zhreshold Added test case for the operator |
zhreshold
approved these changes
Dec 6, 2018
zhaoyao73
pushed a commit
to zhaoyao73/incubator-mxnet
that referenced
this pull request
Dec 13, 2018
zhaoyao73
added a commit
to zhaoyao73/incubator-mxnet
that referenced
this pull request
Dec 13, 2018
* upstream/master: (54 commits) Add notes about debug with libstdc++ symbols (apache#13533) add cpp example inception to nightly test (apache#13534) Fix exception handling api doc (apache#13519) fix link for gluon model zoo (apache#13583) ONNX import/export: Size (apache#13112) Update MXNetTutorialTemplate.ipynb (apache#13568) fix the situation where idx didn't align with rec (apache#13550) Fix use-before-assignment in convert_dot (apache#13511) License update (apache#13565) Update version to v1.5.0 including clojure package (apache#13566) Fix flaky test test_random:test_randint_generator (apache#13498) Add workspace cleaning after job finished (apache#13490) Adding test for softmaxoutput (apache#13116) apache#13441 [Clojure] Add Spec Validations for the Random namespace (apache#13523) Revert "Bumped minor version from 1.4.0 to 1.5.0 on master, updated License file" (apache#13558) Chi_square_check for discrete distribution fix (apache#13543) Updated docs for randint operator (apache#13541) Simplifications and some fun stuff for the MNIST Gluon tutorial (apache#13094) Fix apache#13521 (apache#13537) Add a retry to qemu_provision (apache#13551) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for the failing tutorial mentioned here
#13099
@vandanavk
Checklist
Essentials