This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-1110] Add header files required by horovod #13062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@szha Your review and advice are very much appreciated. |
|
Do we need the headers for the submodules too? That would also become really hard to maintain. |
|
@apeforest Thanks for your contribution! |
|
@rahul003 Yes, because mxnet/engine.h --> mxnet/base.h --> All these submodules. |
|
@apeforest thanks for your contribution. Could you please update your branch and re-trigger CI? @mxnet-label-bot update [pr-awaiting-review] |
|
@mxnet-label-bot update [pr-awaiting-review] |
szha
reviewed
Nov 20, 2018
stu1130
reviewed
Nov 23, 2018
anirudh2290
reviewed
Dec 4, 2018
|
@rahul003 Yes, all the added header files are required by Horovod. |
|
@szha Yes, we have verified that Horovod works well with MXNet with these included header files in pip package. |
anirudh2290
approved these changes
Dec 4, 2018
|
@mxnet-label-bot update [pr-awaiting-merge] |
|
@anirudh2290 Can this PR be merged now? |
This was referenced Dec 8, 2018
Merged
zhaoyao73
pushed a commit
to zhaoyao73/incubator-mxnet
that referenced
this pull request
Dec 13, 2018
* Add header files required by horovod * Add symbolic link and cherry picked required header * add python API to return include path * update link * fix windows CI * fix windows build * fix dlpack link * merge with master * exclude 3rd party header files from license check * exclude license check * exclude include directory * remove commented lines
yuxihu
pushed a commit
to yuxihu/incubator-mxnet
that referenced
this pull request
Jan 9, 2019
* Add header files required by horovod * Add symbolic link and cherry picked required header * add python API to return include path * update link * fix windows CI * fix windows build * fix dlpack link * merge with master * exclude 3rd party header files from license check * exclude license check * exclude include directory * remove commented lines
yuxihu
pushed a commit
to yuxihu/incubator-mxnet
that referenced
this pull request
Jan 14, 2019
* Add header files required by horovod * Add symbolic link and cherry picked required header * add python API to return include path * update link * fix windows CI * fix windows build * fix dlpack link * merge with master * exclude 3rd party header files from license check * exclude license check * exclude include directory * remove commented lines
apeforest
added a commit
to apeforest/incubator-mxnet
that referenced
this pull request
Feb 5, 2019
* Add header files required by horovod * Add symbolic link and cherry picked required header * add python API to return include path * update link * fix windows CI * fix windows build * fix dlpack link * merge with master * exclude 3rd party header files from license check * exclude license check * exclude include directory * remove commented lines
apeforest
added a commit
to apeforest/incubator-mxnet
that referenced
this pull request
Apr 25, 2019
* Add header files required by horovod * Add symbolic link and cherry picked required header * add python API to return include path * update link * fix windows CI * fix windows build * fix dlpack link * merge with master * exclude 3rd party header files from license check * exclude license check * exclude include directory * remove commented lines
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When integrating mxnet with horovod, the callback functions need to use certain MXNet APIs which are not currently explosed in include directory. This PR adds the required header files to the include directory as soft links. The header files are already exported in the pip package and verified on Horovod side.