Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-600][Scala] NDArray auto-collector #11751

Merged
merged 10 commits into from
Jul 19, 2018
Merged

[MXNET-600][Scala] NDArray auto-collector #11751

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9b15341
[Scala] NDArrayCollector for automatically disposing NDArrays
yzhliu Jul 13, 2018
6ab02a3
modify doc for NDArrayCollector
yzhliu Jul 13, 2018
8addba8
modify the function doc of NDArrayCollector.withScope
yzhliu Jul 13, 2018
731066d
remove trivial changes
yzhliu Jul 13, 2018
ddf5daa
put dispose in finally
yzhliu Jul 13, 2018
72cf085
fix jni NDArray signature
yzhliu Jul 13, 2018
f167c62
Merge remote-tracking branch 'upstream/master' into scala-nd-collector
yzhliu Jul 13, 2018
1417472
modify doc and private var
yzhliu Jul 15, 2018
092268e
dispose res when test finishes
yzhliu Jul 15, 2018
60204e1
add comments, change variable name
yzhliu Jul 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix jni NDArray signature
  • Loading branch information
@yzhliu
yzhliu committed Jul 13, 2018
commit 72cf085e4b78c9be4087f983b7ed7788e628da13
2 changes: 1 addition & 1 deletion scala-package/native/src/main/native/org_apache_mxnet_native_c_api.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,7 @@ extern "C" void KVStoreUpdaterCallbackFunc

// find java NDArray constructor
jclass ndObjClass = env->FindClass("org/apache/mxnet/NDArray");
jmethodID ndObjConstructor = env->GetMethodID(ndObjClass, "<init>", "(JZ)V");
jmethodID ndObjConstructor = env->GetMethodID(ndObjClass, "<init>", "(JZZ)V");

jobject ndRecv = env->NewObject(ndObjClass, ndObjConstructor,
reinterpret_cast<jlong>(recv), true);
Expand Down