This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Manually check node existence in CachedOp #11545
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Constructing a weird
CachedOp
directly in C++, in rare cases might lead to rebuildingfull_graph
inCachedOp
without updatingbwd_ograd_dep_
. This potentially causes crash whenOpReqType
of one ofoutputs
ofgrad_graph_
isOpReqType::kNullOp
. This PR enhances the capability ofCachedOp
to handle this case.Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments