This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-531] CNN Examples for Scala new API #11292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently facing the CI problem as shown below: I add a fix on codec to see if we can solve that... Here is the link I found helpful. Cannot reproduce using a ubuntu machine |
|
The previous problem solved, currently facing the memory leak issues: Will try to look into the code to see if we are not disposing some ndarrays |
|
Currently, I have switched from |
lanking520
changed the title
lanking520
force-pushed
the
example-cnn
branch
2 times, most recently
from
acddbe1
to
147972c
Compare
|
@lanking520 |
nswamy
reviewed
Jun 29, 2018
| @@ -0,0 +1,23 @@ | |||
| # CNN Text Classification Example for Scala | |||
| This is the example using Scala type-safe api doing CNN text classification. | |||
| Currently, I cannot reproduce the same result in the python example here. | |||
There was a problem hiding this comment.
This example is only for Illustration and not modeled to achieve the best accuracy.
lanking520
force-pushed
the
example-cnn
branch
2 times, most recently
from
e4729aa
to
539c091
Compare
nswamy
reviewed
Jul 4, 2018
| This is the example using Scala type-safe api doing CNN text classification. | ||
| This example is only for Illustration and not modeled to achieve the best accuracy. | ||
|
|
||
| Please contribute to improve the dev accuracy of the model. |
| */ | ||
| * An Implementation of the paper | ||
| * Convolutional Neural Networks for Sentence Classification | ||
| */ |
| val sm = Symbol.SoftmaxOutput()()(Map("data" -> fc, "label" -> inputY)) | ||
| val fc = Symbol.api.FullyConnected(data = Some(hDrop), num_hidden = numLabel) | ||
| val sm = Symbol.api.SoftmaxOutput(data = Some(fc), label = Some(inputY)) | ||
| fc.dispose() |
There was a problem hiding this comment.
have you checked that this does not crash. Isn't SoftmaxOutput using FC during training
There was a problem hiding this comment.
Yes, I have. Not crashing
|
Can we merge? |
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this pull request
Aug 29, 2018
* init commit for CNN * Add changes to pass CPU and GPU test * Add codec to solve the mkstring issue * Change dropout and epoch number * change epoch to 10 and Java download * add README.md * adding dispose method to avoid memory leaks * dispose unused Symbols
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains examples written from the new API.
@nswamy @yzhliu @andrewfayres
All examples pushed here are tested locally on my Mac. It lives in the new package called
org.apache.mxnet.examplesBe aware: CNN Example is specifically designed to run on GPU. Disable the CPU
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.