Get rid of warnings (#21099)

* Get rid of warnings * Fix clang formatting * Fix problem with redefinition * Fix 'uninitialized' warning * Update CONTRIBUTORS.md
apache · Jul 19, 2022 · 183e012 · 183e012
1 parent 7b1daf9
commit 183e012
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 11 deletions.
diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md
@@ -302,6 +302,7 @@ List of Contributors
 * [Dominika Jedynak](https://github.com/DominikaJedynak)
 * [Adam Grabowski](https://github.com/agrabows)
 * [Kacper Pietkun](https://github.com/Kacper-Pietkun)
+* [Hanna Jarlaczyńska](https://github.com/hankaj)
 
 Label Bot
 ---------

diff --git a/src/operator/c_lapack_api.h b/src/operator/c_lapack_api.h
@@ -1045,6 +1045,14 @@ MXNET_LAPACK_CWRAPPER12(dorgqr, double)
 #undef MXNET_LAPACK_CWRAPPER2
 #undef MXNET_LAPACK_CWRAPPER3
 #undef MXNET_LAPACK_CWRAPPER4
+#undef MXNET_LAPACK_CWRAPPER5
+#undef MXNET_LAPACK_CWRAPPER6
+#undef MXNET_LAPACK_CWRAPPER7
+#undef MXNET_LAPACK_CWRAPPER8
+#undef MXNET_LAPACK_CWRAPPER9
+#undef MXNET_LAPACK_CWRAPPER10
+#undef MXNET_LAPACK_CWRAPPER11
+#undef MXNET_LAPACK_CWRAPPER12
 #undef MXNET_LAPACK_UNAVAILABLE
 #endif
 

diff --git a/src/operator/quantization/dnnl/dnnl_quantized_rnn.cc b/src/operator/quantization/dnnl/dnnl_quantized_rnn.cc
@@ -279,8 +279,6 @@ void DNNLQuantizedRnnOp::Forward(const OpContext& op_ctx,
  char* dst_state = nullptr; // Output state
  char* src_state_cell = nullptr; // Used in LSTM for cell state
  char* dst_state_cell = nullptr; // Used in LSTM for cell state
- const size_t cell_bytes = (default_param.bidirectional + 1) * default_param.batch_size_ *
- default_param.state_size * mshadow::mshadow_sizeof(data_dtype);
 
  if (default_param.state_outputs && req[rnn_enum::kStateOut] != kNullOp) {
  stateout_mem =

diff --git a/src/operator/tensor/broadcast_reduce-inl.h b/src/operator/tensor/broadcast_reduce-inl.h
@@ -327,7 +327,7 @@ MSHADOW_XINLINE std::pair<AType, AType> seq_reduce_assign_block(size_t start,
  const Shape<ndim>& rshape,
  const Shape<ndim>& rstride) {
  Shape<ndim> coord;
- AType val, residual;
+ AType val, residual{};
  Reducer::SetInitValue(val, residual);
  for (size_t k = start; k < start + len; ++k) {
  coord = mxnet_op::unravel(k, rshape);

diff --git a/src/operator/tensor/index_update-inl.h b/src/operator/tensor/index_update-inl.h
@@ -254,7 +254,6 @@ inline void IndexUpdateOpBackwardA(const nnvm::NodeAttrs& attrs,
  TBlob ograd = inputs[0];
  TBlob ind = inputs[1];
  const TBlob& grad_a = outputs[0];
- mshadow::Stream<xpu>* s = ctx.get_stream<xpu>();
  // get the number of 'ind' index
  if (ind.shape_.ndim() == 0) {
  ind.shape_ = Shape2(1, 1);

diff --git a/tests/cpp/engine/threaded_engine_test.cc b/tests/cpp/engine/threaded_engine_test.cc
@@ -51,8 +51,6 @@ struct Workload {
  int time;
 };
 
-static uint32_t seed_ = 0xdeadbeef;
-
 /**
  * generate a list of workloads
  */

diff --git a/tests/cpp/include/test_util.h b/tests/cpp/include/test_util.h
@@ -787,11 +787,11 @@ struct ScopeSet {
  T saveValue_;
 };
 
-static void AssertEqual(const std::vector<NDArray*>& in_arrs,
- const std::vector<NDArray*>& out_arrs,
- float rtol = 1e-5,
- float atol = 1e-8,
- bool test_first_only = false) {
+static inline void AssertEqual(const std::vector<NDArray*>& in_arrs,
+  const std::vector<NDArray*>& out_arrs,
+  float rtol = 1e-5,
+  float atol = 1e-8,
+  bool test_first_only = false) {
  for (size_t j = 0; j < in_arrs.size(); ++j) {
  // When test_all is fir
  if (test_first_only && j == 1) {