Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUREFIRE-2135] Use native.encoding for parsing ps #584

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

andpab
Copy link
Contributor

@andpab andpab commented Dec 18, 2022

  • Use the value of the system property native.encoding as charset for parsing the output of the ps command that ForkedBooter issues on Unix-like OSes when checking if the forked process is still alive
  • Fall back to UTF-8 in case the system property is absent (pre-JDK17)
  • Remove an unnecessary System.out.println in a test that was probably committed by accident

This fixes the ConsoleOutputIT on Java 18 and above.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@slawekjaranowski
Copy link
Member

@andpab thanks 👏

@andpab
Copy link
Contributor Author

andpab commented Dec 19, 2022

Amended the commit as suggested by @michael-o

New commit message is:

- Use the value of the system property native.encoding as charset for
  parsing the output of the ps command that ForkedBooter issues on
  Unix-like OSes when checking if the forked process is still alive
- Fall back to file.encoding if native.encoding is absent (pre-JDK17)
- Fall back further to UTF-8 if file.encoding is not explicitly given
- Remove an unnecessary System.out.println in a test that was probably
  committed by accident

This fixes the ConsoleOutputIT on Java 18 and above.

@slawekjaranowski
Copy link
Member

issue number should be in square brackets in commit subject, I can change it during merging 😄

- Use the value of the system property native.encoding as charset for
  parsing the output of the ps command that ForkedBooter issues on
  Unix-like OSes when checking if the forked process is still alive
- Fall back to file.encoding if native.encoding is absent (pre-JDK17)
- Fall back further to UTF-8 if file.encoding is not explicitly given
- Remove an unnecessary System.out.println in a test that was probably
  committed by accident

This fixes the ConsoleOutputIT on Java 18 and above.
@andpab
Copy link
Contributor Author

andpab commented Dec 19, 2022

I've amended the commit to add the brackets to the issue reference in the commit message.

Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@slawekjaranowski slawekjaranowski merged commit 12b9679 into apache:master Dec 19, 2022
@andpab andpab deleted the SUREFIRE-2135 branch December 19, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants