MINOR: Improvements to release.py #15651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
omkreddy
commented
Apr 4, 2024
•
- Update release.py to trim "-SNAPSHOT" from docs/js/templateData.js while adding "Bump version commit" during release process.
- Add blog entry details to announcement_email template
b2b1e80
to
0ce0529
Compare
chia7712
approved these changes
Apr 5, 2024
release.py
Outdated
| @@ -348,6 +348,9 @@ def command_release_announcement_email(): | |||
|
|
|||
| <DETAILS OF THE CHANGES> | |||
|
|
|||
| An overview of the release and its notable changes can be found in the | |||
| release blog post: <LINK TO THE KAFKA BLOG> | |||
There was a problem hiding this comment.
Can we generate the link automatically if the link formate is like https://kafka.apache.org/blog#apache_kafka_362_release_announcement
There was a problem hiding this comment.
Thanks for the review,. updated the PR
0ce0529
to
ba9dfc7
Compare
Phuc-Hong-Tran
pushed a commit
to Phuc-Hong-Tran/kafka
that referenced
this pull request
Jun 6, 2024
Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.