MINOR: Fix ClusterConnectionStatesTest.testSingleIP #14741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
showuon
approved these changes
Nov 12, 2023
|
Shall we backport this to 3.6 as well? Maybe not a huge deal, but I see it causing some issues there too. |
lucasbru
pushed a commit
to lucasbru/kafka
that referenced
this pull request
Dec 29, 2023
This test fails because `localhost` resolved to more than one IP on the Ci. This patch updates the ClusterConnectionStatesTest.testSingleIP test to use a static resolver. Reviewers: Luke Chen <[email protected]>
rreddy-22
pushed a commit
to rreddy-22/kafka-rreddy
that referenced
this pull request
Jan 2, 2024
This test fails because `localhost` resolved to more than one IP on the Ci. This patch updates the ClusterConnectionStatesTest.testSingleIP test to use a static resolver. Reviewers: Luke Chen <[email protected]>
yyu1993
pushed a commit
to yyu1993/kafka
that referenced
this pull request
Feb 15, 2024
This test fails because `localhost` resolved to more than one IP on the Ci. This patch updates the ClusterConnectionStatesTest.testSingleIP test to use a static resolver. Reviewers: Luke Chen <[email protected]>
clolov
pushed a commit
to clolov/kafka
that referenced
this pull request
Apr 5, 2024
This test fails because `localhost` resolved to more than one IP on the Ci. This patch updates the ClusterConnectionStatesTest.testSingleIP test to use a static resolver. Reviewers: Luke Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test fails because
localhostresolved to more than one IP on the Ci. This patch updates the ClusterConnectionStatesTest.testSingleIP test to use a static resolver.I was considering whether this test adds any value at all but it seems to ensure that the same ip address is used after reconnecting.
Committer Checklist (excluded from commit message)