Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR; Fix KRaft metadata version system tests #14722

Merged
merged 2 commits into from
Nov 9, 2023
Merged

MINOR; Fix KRaft metadata version system tests #14722

merged 2 commits into from
Nov 9, 2023

Conversation

jsancio
Copy link
Member

@jsancio jsancio commented Nov 9, 2023

The latest metadata version is now 3.7. Fix the KRaft upgrade system test to upgrade to that version instead of 3.6.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@jsancio
MINOR; Fix KRaft metadata version tests
995a703 
The latest metadata version is now 3.7. Fix the KRaft upgrade
test to upgrade to that version instead of 3.6.
@jsancio jsancio added the kraft label Nov 9, 2023
@jsancio
Copy link
Member Author

jsancio commented Nov 9, 2023

I started a system test build for this branch. I'll report back when it finishes.

mumrah
mumrah approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@mumrah mumrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsancio the change LGTM pending a successful system test run

@jsancio
MINOR; Use version 3.3.2
ff8eede 
Change the vagrant setup to use 3.3.2 instead of 3.3.1. Also update the
dependencies in gradle.
@jsancio
Copy link
Member Author

jsancio commented Nov 9, 2023

Thanks for the review @mumrah . The system test failed because the 3.3.x version was not current. Fixed and rerunning the system tests.

@jsancio
Copy link
Member Author

jsancio commented Nov 9, 2023

System tests are green.

================================================================================
SESSION REPORT (ALL TESTS)
ducktape version: 0.8.14
session_id:       2023-11-09--001
run time:         10 minutes 45.434 seconds
tests run:        12
passed:           12
flaky:            0
failed:           0
ignored:          0
================================================================================
test_id:    kafkatest.tests.core.kraft_upgrade_test.TestKRaftUpgrade.test_isolated_mode_upgrade.from_kafka_version=3.3.2.metadata_quorum=ISOLATED_KRAFT
status:     PASS
run time:   3 minutes 22.675 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.core.kraft_upgrade_test.TestKRaftUpgrade.test_combined_mode_upgrade.from_kafka_version=3.1.2.metadata_quorum=COMBINED_KRAFT
status:     PASS
run time:   3 minutes 26.013 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.core.kraft_upgrade_test.TestKRaftUpgrade.test_isolated_mode_upgrade.from_kafka_version=3.1.2.metadata_quorum=ISOLATED_KRAFT
status:     PASS
run time:   3 minutes 34.273 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.core.kraft_upgrade_test.TestKRaftUpgrade.test_isolated_mode_upgrade.from_kafka_version=3.2.3.metadata_quorum=ISOLATED_KRAFT
status:     PASS
run time:   3 minutes 56.827 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.core.kraft_upgrade_test.TestKRaftUpgrade.test_combined_mode_upgrade.from_kafka_version=3.2.3.metadata_quorum=COMBINED_KRAFT
status:     PASS
run time:   3 minutes 8.597 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.core.kraft_upgrade_test.TestKRaftUpgrade.test_isolated_mode_upgrade.from_kafka_version=3.5.1.metadata_quorum=ISOLATED_KRAFT
status:     PASS
run time:   3 minutes 17.410 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.core.kraft_upgrade_test.TestKRaftUpgrade.test_isolated_mode_upgrade.from_kafka_version=dev.metadata_quorum=ISOLATED_KRAFT
status:     PASS
run time:   3 minutes 13.048 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.core.kraft_upgrade_test.TestKRaftUpgrade.test_isolated_mode_upgrade.from_kafka_version=3.4.1.metadata_quorum=ISOLATED_KRAFT
status:     PASS
run time:   3 minutes 52.438 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.core.kraft_upgrade_test.TestKRaftUpgrade.test_combined_mode_upgrade.from_kafka_version=3.3.2.metadata_quorum=COMBINED_KRAFT
status:     PASS
run time:   3 minutes 3.473 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.core.kraft_upgrade_test.TestKRaftUpgrade.test_combined_mode_upgrade.from_kafka_version=3.4.1.metadata_quorum=COMBINED_KRAFT
status:     PASS
run time:   2 minutes 52.462 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.core.kraft_upgrade_test.TestKRaftUpgrade.test_combined_mode_upgrade.from_kafka_version=3.5.1.metadata_quorum=COMBINED_KRAFT
status:     PASS
run time:   3 minutes 1.467 seconds
--------------------------------------------------------------------------------
test_id:    kafkatest.tests.core.kraft_upgrade_test.TestKRaftUpgrade.test_combined_mode_upgrade.from_kafka_version=dev.metadata_quorum=COMBINED_KRAFT
status:     PASS
run time:   3 minutes 35.485 seconds
--------------------------------------------------------------------------------

@jsancio jsancio merged commit 35317d8 into apache:trunk Nov 9, 2023
1 check was pending
@jsancio jsancio deleted the minor-fix-upgrade-test branch November 9, 2023 20:03
@jolshan
Copy link
Contributor

jolshan commented Dec 14, 2023

I think we shouldn't have removed 3.3.1 generally. I've addressed it in a PR I opened a while ago.
#14641

@jolshan
Copy link
Contributor

jolshan commented Dec 14, 2023

Oh I see we don't seem to test 3.3.1. I guess I can remove that from my change then 👍

rreddy-22 pushed a commit to rreddy-22/kafka-rreddy that referenced this pull request Jan 2, 2024
@jsancio @rreddy-22
MINOR; Fix KRaft metadata version system tests (apache#14722)
164e9db 
The latest metadata version is now 3.7. Fix the KRaft upgrade
test to upgrade to that version instead of 3.6.

Change the vagrant setup and gradle dependencies to use 3.3.2 instead of 3.3.1.

Reviewers: David Arthur <[email protected]>
yyu1993 pushed a commit to yyu1993/kafka that referenced this pull request Feb 15, 2024
@jsancio @yyu1993
MINOR; Fix KRaft metadata version system tests (apache#14722)
cb7d6dd 
The latest metadata version is now 3.7. Fix the KRaft upgrade
test to upgrade to that version instead of 3.6.

Change the vagrant setup and gradle dependencies to use 3.3.2 instead of 3.3.1.

Reviewers: David Arthur <[email protected]>
AnatolyPopov pushed a commit to aiven/kafka that referenced this pull request Feb 16, 2024
@jsancio @AnatolyPopov
MINOR; Fix KRaft metadata version system tests (apache#14722)
07ba76e 
The latest metadata version is now 3.7. Fix the KRaft upgrade
test to upgrade to that version instead of 3.6.

Change the vagrant setup and gradle dependencies to use 3.3.2 instead of 3.3.1.

Reviewers: David Arthur <[email protected]>
clolov pushed a commit to clolov/kafka that referenced this pull request Apr 5, 2024
@jsancio @clolov
MINOR; Fix KRaft metadata version system tests (apache#14722)
1e23468 
The latest metadata version is now 3.7. Fix the KRaft upgrade
test to upgrade to that version instead of 3.6.

Change the vagrant setup and gradle dependencies to use 3.3.2 instead of 3.3.1.

Reviewers: David Arthur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumrah mumrah mumrah approved these changes

Assignees
No one assigned
Labels
kraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsancio @jolshan @mumrah