Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Fix GroupCoordinatorShardTest stubbing #14637

Merged
merged 4 commits into from
Nov 15, 2023
Merged

MINOR: Fix GroupCoordinatorShardTest stubbing #14637

merged 4 commits into from
Nov 15, 2023

Conversation

iamlockon
Copy link
Contributor

@iamlockon iamlockon commented Oct 25, 2023 •
edited
Loading

Originally the assert and stub statements did not verify correctly, so assertEquals will always be true.
I have checked the whole file and fixed them.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@iamlockon iamlockon changed the title MINOR: Fix UT stubbing MINOR: Fix GroupCoordinatorShardTest stubbing Oct 25, 2023
@hudeqi hudeqi added the tests Test fixes (including flaky tests) label Oct 26, 2023
@dajac dajac added the KIP-848 The Next Generation of the Consumer Rebalance Protocol label Oct 28, 2023
dajac
dajac approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@dajac dajac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch!

@dajac
Copy link
Contributor

dajac commented Nov 9, 2023

Re-triggered a build because the last one failed due to, it seems, unrelated things. I merge if the next build passes.

@dajac dajac merged commit a64037c into apache:trunk Nov 15, 2023
1 check failed
rreddy-22 pushed a commit to rreddy-22/kafka-rreddy that referenced this pull request Jan 2, 2024
@iamlockon @rreddy-22
MINOR: Fix GroupCoordinatorShardTest stubbing (apache#14637)
c1bc18f 
This patch fixes incorrect stubs in GroupCoordinatorShardTest.

Reviewers: David Jacot <[email protected]>
yyu1993 pushed a commit to yyu1993/kafka that referenced this pull request Feb 15, 2024
@iamlockon @yyu1993
MINOR: Fix GroupCoordinatorShardTest stubbing (apache#14637)
e4c0252 
This patch fixes incorrect stubs in GroupCoordinatorShardTest.

Reviewers: David Jacot <[email protected]>
AnatolyPopov pushed a commit to aiven/kafka that referenced this pull request Feb 16, 2024
@iamlockon @AnatolyPopov
MINOR: Fix GroupCoordinatorShardTest stubbing (apache#14637)
c6aa59a 
This patch fixes incorrect stubs in GroupCoordinatorShardTest.

Reviewers: David Jacot <[email protected]>
clolov pushed a commit to clolov/kafka that referenced this pull request Apr 5, 2024
@iamlockon @clolov
MINOR: Fix GroupCoordinatorShardTest stubbing (apache#14637)
c7eb163 
This patch fixes incorrect stubs in GroupCoordinatorShardTest.

Reviewers: David Jacot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dajac dajac dajac approved these changes

Assignees
No one assigned
Labels
KIP-848 The Next Generation of the Consumer Rebalance Protocol tests Test fixes (including flaky tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamlockon @dajac @hudeqi