Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-14709: Move content in connect/mirror/README.md to the docs #13650

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

tinaselenge
Copy link
Contributor

Most of the contents in the README.md was already covered in the docs therefore only had to add the section for Exactly Once support.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Copy link
Contributor

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor suggestion, otherwise it looks good to me.

docs/ops.html Outdated Show resolved Hide resolved
Co-authored-by: Manyanda Chitimbo <[email protected]>
Copy link
Contributor

@showuon showuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tinaselenge , thanks for the PR, left a comment.

primary.consumer.isolation.level = read_committed
primary.admin.bootstrap.servers = localhost:9092

### Shared configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this Shared configuration is mentioned in the doc. Could you check it again?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is already included in the doc.

MirrorMaker processes share configuration via their target Kafka clusters. This behavior may cause conflicts when configurations differ among MirrorMaker processes that operate against the same target cluster.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you're right. It's just not having the same title. Thanks.

Copy link
Contributor

@showuon showuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

primary.consumer.isolation.level = read_committed
primary.admin.bootstrap.servers = localhost:9092

### Shared configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you're right. It's just not having the same title. Thanks.

@showuon
Copy link
Contributor

showuon commented Jun 14, 2023

@showuon
Copy link
Contributor

showuon commented Jun 15, 2023

Failed tests are unrelated:

    Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testSyncTopicConfigs()
    Build / JDK 11 and Scala 2.13 / kafka.admin.DescribeConsumerGroupTest.testDescribeOffsetsOfExistingGroupWithNoMembers()
    Build / JDK 11 and Scala 2.13 / kafka.zk.ZkMigrationIntegrationTest.[1] Type=ZK, Name=testNewAndChangedTopicsInDualWrite, MetadataVersion=3.4-IV0, Security=PLAINTEXT
    Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.DedicatedMirrorIntegrationTest.testMultiNodeCluster()
    Build / JDK 8 and Scala 2.12 / kafka.api.ConsumerBounceTest.testClose()
    Build / JDK 8 and Scala 2.12 / kafka.api.PlaintextConsumerTest.testMaxPollIntervalMs()
    Build / JDK 8 and Scala 2.12 / org.apache.kafka.streams.integration.StoreUpgradeIntegrationTest.shouldMigratePersistentKeyValueStoreToTimestampedKeyValueStoreUsingPapi

@showuon showuon merged commit 930744c into apache:trunk Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants