-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-14709: Move content in connect/mirror/README.md to the docs #13650
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor suggestion, otherwise it looks good to me.
Co-authored-by: Manyanda Chitimbo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tinaselenge , thanks for the PR, left a comment.
primary.consumer.isolation.level = read_committed | ||
primary.admin.bootstrap.servers = localhost:9092 | ||
|
||
### Shared configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this Shared configuration
is mentioned in the doc. Could you check it again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is already included in the doc.
Line 874 in f275ed8
MirrorMaker processes share configuration via their target Kafka clusters. This behavior may cause conflicts when configurations differ among MirrorMaker processes that operate against the same target cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, you're right. It's just not having the same title. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
primary.consumer.isolation.level = read_committed | ||
primary.admin.bootstrap.servers = localhost:9092 | ||
|
||
### Shared configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, you're right. It's just not having the same title. Thanks.
Re-triggering the CI: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13650/3/ |
Failed tests are unrelated:
|
Most of the contents in the README.md was already covered in the docs therefore only had to add the section for Exactly Once support.
Committer Checklist (excluded from commit message)