KAFKA-13284: Use sftp to upload artifacts in release.py #11394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- automatically upload artifacts to Apache Home using sftp - fix the logic to find JDK 17
mimaison
commented
Oct 13, 2021
release.py
Outdated
| fail("JDK 8 is required") | ||
| elif "%d.0" % version not in javaVersion: | ||
| elif "%d" % version not in java_version: |
There was a problem hiding this comment.
OpenJDK 17 version:
openjdk version "17" 2021-09-14
OpenJDK Runtime Environment Temurin-17+35 (build 17+35)
OpenJDK 64-Bit Server VM Temurin-17+35 (build 17+35, mixed mode, sharing)
dajac
reviewed
Oct 15, 2021
| @@ -621,7 +631,8 @@ def select_gpg_key(): | |||
| cmd("Listing artifacts to be uploaded:", "ls -R %s" % artifacts_dir) | |||
|
|
|||
| cmd("Zipping artifacts", "tar -czf %s.tar.gz %s" % (artifact_name, artifact_name), cwd=work_dir) | |||
| if not user_ok("Have you uploaded artifacts in %s, listed above, to public_html in your Apache home directory (y/n)?: " % artifacts_dir): | |||
| sftp_upload(artifacts_dir) | |||
There was a problem hiding this comment.
Should we also call sftp_mkdir before to ensure that the directory exists?
There was a problem hiding this comment.
I meant public_html directory.
There was a problem hiding this comment.
Yes that's what I understood. I've made the changes, testing it now ...
There was a problem hiding this comment.
Thanks for the suggestion, I pushed an update
release.py
Outdated
| cd public_html | ||
| put -r %s | ||
| """ % dir | ||
| cmd("Uploading '%s' under public_html in your Apache home directory" % dir, "sftp -b - %[email protected]" % apache_id, stdin=cmd_str, allow_failure=True, num_retries=3) |
There was a problem hiding this comment.
I guess that we assume that the relevant key is in the ssh-agent, right?
There was a problem hiding this comment.
Yes like it used to work with rsync
xdgrulez
pushed a commit
to xdgrulez/kafka
that referenced
this pull request
Dec 22, 2021
- automatically upload artifacts to Apache Home using sftp - fix the logic to find JDK 17 Reviewers: David Jacot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Checklist (excluded from commit message)