KAFKA-13385: In the KRPC request header, translate null clientID to empty #11385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
socutes
approved these changes
Oct 13, 2021
|
Good catch. Could we add a test to avoid this regression in the future? |
Yes, absolutely. I actually posted this without a test only to try to find out which junit test would fail when I changed the null handling. Unfortunately, it seems like none of them did! (Or rather, the only test failures I see in this run are unrelated test flakes.) I'll add a unit test for this case. |
3 tasks
xdgrulez
pushed a commit
to xdgrulez/kafka
that referenced
this pull request
Dec 22, 2021
…mpty (apache#11385) Reviewers: David Jacot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a historical quirk, the clientId field is nullable in the request header schema. However, the code does
not handle null clientIds. They should be treated as the empty string, as they were previously.