Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JCR-4085 - always include property type data for DOUBLE #50

Open
wants to merge 7,690 commits into
base: trunk
Choose a base branch
from
Open

JCR-4085 - always include property type data for DOUBLE #50

wants to merge 7,690 commits into from

Conversation

justinedelson
Copy link
Contributor

@justinedelson justinedelson commented Dec 14, 2016 •
edited
Loading

As discussed in https://issues.apache.org/jira/browse/JCR-4085, JSON only has a single numeric type, so type inference cannot be used to differentiate between whole numbers in a LONG and DOUBLE field. To compensate for this and allow clients to properly understand the property types, DOUBLE properties should always contain type information, as is already done for DECIMAL types.

amitj and others added 30 commits October 17, 2014 07:30
JCR-3816: [aws-ext]S3DS not able update lastModified of record > 5GB
986a497 
JCR-3817: [jackrabbit-aws-ext] Performance of operation degrades while running DS GC

Applying patch from Shashank Gupta

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1632482 13f79535-47bb-0310-9956-ffa450edef68
@mreutegg
JCR-3825: Use RepositoryFactory for first hops
dcba564 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1633070 13f79535-47bb-0310-9956-ffa450edef68
@mreutegg
JCR-3274: jackrabbit-standalone-2.4.0.jar Populate does not work
7400f1d 
This closes apache#20

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1633086 13f79535-47bb-0310-9956-ffa450edef68
@mreutegg
JCR-3825: Use RepositoryFactory for first hops
63b8d83 
Depend on Oak 1.1-SNAPSHOT for now until 1.1.2 or newer is available

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1633758 13f79535-47bb-0310-9956-ffa450edef68
JCR-3826: AbstractPrincipalProvider cachesize is not configurable
4fb740c 
LoginModule configurations without an explicit principal provider class name will now be applied to the DefaultPrincipalProvider.


git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1634584 13f79535-47bb-0310-9956-ffa450edef68
@thomasmueller
JCR-3429 Make query tests (more) independent
b4d01c7 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1636607 13f79535-47bb-0310-9956-ffa450edef68
@anchela
minor improvement: adding @OverRide annotations, removing unused impo…
7e85f66 
…rts, replacing Session#checkPermission by #hasPermission

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1640344 13f79535-47bb-0310-9956-ffa450edef68
@anchela
minor improvement: adding @OverRide, removing unused imports and repl…
8a488ac 
…acing Session.checkPermission by Session.hasPermission

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1640530 13f79535-47bb-0310-9956-ffa450edef68
@anchela
JCR-3830 : Allow for privilege discovery in jcr-server
10dc451 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1640531 13f79535-47bb-0310-9956-ffa450edef68
@anchela
JCR-2113 : WIP (Contribution by Alfusainey Jallow)
961bfb7 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1640892 13f79535-47bb-0310-9956-ffa450edef68
@anchela
JCR-2113 : WIP (Contribution by Alfusainey Jallow), fixing issue intr…
0679fd1 
…oduced by angela

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1640897 13f79535-47bb-0310-9956-ffa450edef68
JCR-3833 LinkedHashMap#entrySet#iterator#remove no longer calls Linke…
78700c7 
…dHashMap#remove, however LocalCache relies on that when it overrides the #remove method.

Note that this issue did not turn up during running the tests because TestLocalCache#testAutoPurge is disabled due to JCR-3806...

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1643091 13f79535-47bb-0310-9956-ffa450edef68
JCR-3834 add commented out unit test, skip unit test that fails on ja…
4240329 
…va 8

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1643520 13f79535-47bb-0310-9956-ffa450edef68
JCR-3835 add ReplacePropertyWhileOthersReadTest to list of known issues
dd2082d 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1643522 13f79535-47bb-0310-9956-ffa450edef68
JCR-3833 update to latest surefire plugin in order to be able to use …
eb2b64a 
…runOrder configuration option. This is needed because the default order in which the tests are executed in the jackrabbit-spi2jcr module causes test failures on Java 8

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1643781 13f79535-47bb-0310-9956-ffa450edef68
@mreutegg
JCR-2113: JSR 283 Access Control Management
08f0a53 
Add missing license headers

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1643812 13f79535-47bb-0310-9956-ffa450edef68
@mreutegg
JCR-3825: Use RepositoryFactory for first hops
f96f68c 
Use released version of Oak

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1643994 13f79535-47bb-0310-9956-ffa450edef68
JCR-3840 take same-name child type definitions into account when rere…
6ac6e6b 
…gistering node types

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1644405 13f79535-47bb-0310-9956-ffa450edef68
@amit-jain
JCR-3838: [aws-ext] Proactive & Asynchronous caching of binary when i…
5439e4a 
…ts metadata is accessed from S3

Patch from Shashank

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1644549 13f79535-47bb-0310-9956-ffa450edef68
@amit-jain
JCR-3839: [aws-ext] Regression to JCR-3734 Slow local cache built-up …
0bc2d85 
…time

Patch from Shashank

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1644551 13f79535-47bb-0310-9956-ffa450edef68
JCR-3840 limit the number of null child node definitions to match wit…
ef17e9a 
…h to the number of slots available

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1644665 13f79535-47bb-0310-9956-ffa450edef68
JCR-3840 limit the number of null child node definitions to match wit…
ad141a9 
…h to the number of slots available

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1644668 13f79535-47bb-0310-9956-ffa450edef68
@anchela
JCR-2113 : JSR 283 Access Control Management (patch provided by alfus…
74c7a70 
…ainey jallow, commit with minor modifications and some TODOs (in particular testing).

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1646435 13f79535-47bb-0310-9956-ffa450edef68
@amit-jain
JCR-3843: [jackrabbit-aws-ext] Support S3 in Franfurt Datacenter
79a6248 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1647241 13f79535-47bb-0310-9956-ffa450edef68
@anchela
JCR-3845 : Have AuthorizableQueryManager Support Specifying Sort Igno…
f802188 
…re Case Mode (patch provided by dominique jaeggi)

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1653275 13f79535-47bb-0310-9956-ffa450edef68
@anchela
JCR-3844 : JcrRemotingServlet does not log full stacktrace
c5dd92a 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1653309 13f79535-47bb-0310-9956-ffa450edef68
@anchela
OAK-2412 : test cases
b1ed2ca 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1653930 13f79535-47bb-0310-9956-ffa450edef68
@anchela
OAK-2441 : add test-cases to jackrabbit 2.x
9812191 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1653935 13f79535-47bb-0310-9956-ffa450edef68
@anchela
JCR-2113 : JSR 283 Access Control Management (improve privilege disco…
28592a4 
…very as discussed during f2f meeting with alfusainey and david, january 21)

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1653976 13f79535-47bb-0310-9956-ffa450edef68
@anchela
fix indention
a081c99 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1656043 13f79535-47bb-0310-9956-ffa450edef68
reschke and others added 26 commits December 4, 2016 12:32
@reschke
JCR-4064: Refactor WebDAV related code out of HttpClient3-specific cl…
5f61414 
…asses for better future re-use

Make internal method private.

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1772530 13f79535-47bb-0310-9956-ffa450edef68
@reschke
JCR-4064: Refactor WebDAV related code out of HttpClient3-specific cl…
4194ec9 
…asses for better future re-use

Make throws clauses less verbose.

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1772544 13f79535-47bb-0310-9956-ffa450edef68
@reschke
JCR-4070: release Jackrabbit 2.13.5 - release notes
35e7640 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1772545 13f79535-47bb-0310-9956-ffa450edef68
@reschke
[maven-release-plugin] prepare for next development iteration
22e5f28 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1772548 13f79535-47bb-0310-9956-ffa450edef68
@reschke
[maven-release-plugin] rollback the release of jackrabbit-2.13.5
698023a 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1772549 13f79535-47bb-0310-9956-ffa450edef68
@reschke
[maven-release-plugin] prepare release jackrabbit-2.13.5
d44afb3 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1772551 13f79535-47bb-0310-9956-ffa450edef68
@reschke
[maven-release-plugin] prepare for next development iteration
4aa708b 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1772553 13f79535-47bb-0310-9956-ffa450edef68
@reschke
[maven-release-plugin] rollback the release of jackrabbit-2.13.5
5f61378 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1772558 13f79535-47bb-0310-9956-ffa450edef68
@reschke
[maven-release-plugin] prepare release jackrabbit-2.13.5
3b33e37 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1772562 13f79535-47bb-0310-9956-ffa450edef68
@reschke
[maven-release-plugin] rollback the release of jackrabbit-2.13.5
35f69fe 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1772563 13f79535-47bb-0310-9956-ffa450edef68
@reschke
[maven-release-plugin] prepare release jackrabbit-2.13.5
fb359bb 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1772565 13f79535-47bb-0310-9956-ffa450edef68
@reschke
[maven-release-plugin] rollback the release of jackrabbit-2.13.5
9a6414c 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1772566 13f79535-47bb-0310-9956-ffa450edef68
@reschke
[maven-release-plugin] prepare release jackrabbit-2.13.5
3dd1069 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1772569 13f79535-47bb-0310-9956-ffa450edef68
@reschke
[maven-release-plugin] prepare for next development iteration
97a8bfb 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1772571 13f79535-47bb-0310-9956-ffa450edef68
@amit-jain
JCR-4073: jackrabbit-data: occasional test failures in TestLocalCache…
1886df8 
….testAutoPurge

Patch from Wonsan Ko
* Wait until purge job finishes
* reduce sleep to 500 ms

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1772597 13f79535-47bb-0310-9956-ffa450edef68
@amit-jain
JCR-4073: jackrabbit-data: occasional test failures in TestLocalCache…
b61d1a0 
….testAutoPurge

Increased sleep to back to 1000 ms (saw a failure in 15-20 runs)

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1772822 13f79535-47bb-0310-9956-ffa450edef68
@reschke
JCR-4077: change vfs ext test cases not to depend on http client
9daaea5 
(ack Woonsan Ko)

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1773303 13f79535-47bb-0310-9956-ffa450edef68
@reschke
JCR-4078: occasional test failure in GarbageCollectorTest.testSimulat…
83c9332 
…enousRunGC

whitespace, typos, slightly improved diagnostics

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1773332 13f79535-47bb-0310-9956-ffa450edef68
@reschke
JCR-4079: incorrect PROPPATCH response error handling
1f1fcc1 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1773579 13f79535-47bb-0310-9956-ffa450edef68
@reschke
JCR-4080: upgrade Apache Commons Collections to v3.2.2
02b67cd 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1773591 13f79535-47bb-0310-9956-ffa450edef68
@reschke
JCR-4081: Upgrade Apache Commons IO to 2.5
56b0297 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1773745 13f79535-47bb-0310-9956-ffa450edef68
@reschke
JCR-4065: add WebDAV API based on HttpClient4
6882d51 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1773809 13f79535-47bb-0310-9956-ffa450edef68
@reschke
JCR-4060: unintended export versions due to changed defaults in maven…
7065e86 
… bundle plugin

add explicit version numbers for the affected packages, freezing them at 2.13.5

git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1774021 13f79535-47bb-0310-9956-ffa450edef68
@reschke
JCR-4065: add WebDAV API based on HttpClient4 - deprecate old variants
c3e3160 
git-svn-id: https://svn.apache.org/repos/asf/jackrabbit/trunk@1774034 13f79535-47bb-0310-9956-ffa450edef68
@justinedelson
JCR-4085 - always include property type data for DOUBLE
17fcced
@justinedelson
JCR-4085 - formatting
fce1c0d
@reschke
Copy link
Contributor

reschke commented Dec 14, 2016

Any chance to add a few unit tests?

@justinedelson
Copy link
Contributor Author

added unit test for this behavior. My preference would have been to add a dependency to something like https://github.com/skyscreamer/JSONassert, but it seemed like overkill to add an additional test dependency just for this one case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.