Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JCR-5095 Improve exception handling in TokenBasedLoginTest #213

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

kwin
Copy link
Member

@kwin kwin commented Aug 5, 2024

This exposes the full stack trace of the exception within an arbitrary failing thread and exposes the exception of the other threads as suppressed exceptions.

@kwin kwin requested review from anchela and reschke August 5, 2024 14:36
Copy link
Contributor

@reschke reschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you refactored the test, that makes it hard to review.

But if you believe this makes it easier to debug, go ahead.

@kwin
Copy link
Member Author

kwin commented Aug 5, 2024

@reschke
Copy link
Contributor

reschke commented Aug 5, 2024

(still a big change!)

@kwin kwin force-pushed the bugfix/improve-error-handing-in-tokenbasedlogintest branch from 12e9c98 to fbfe051 Compare August 5, 2024 15:40
@kwin kwin force-pushed the bugfix/improve-error-handing-in-tokenbasedlogintest branch from fbfe051 to 46177c5 Compare August 5, 2024 15:41
@kwin kwin merged commit a4a3c7c into trunk Aug 5, 2024
@kwin kwin deleted the bugfix/improve-error-handing-in-tokenbasedlogintest branch August 5, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants