Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: modify and translate schema-api #214

Merged
merged 4 commits into from
May 14, 2023
Merged

docs: modify and translate schema-api #214

merged 4 commits into from
May 14, 2023

Conversation

liuxiaocs7
Copy link
Member

@liuxiaocs7 liuxiaocs7 commented May 11, 2023 •
edited
Loading

subtask of #109
as title

@liuxiaocs7
Copy link
Member Author

The examples in schema info and load demo are the same, but I noticed that some types are different, so I replaced them all directly.

@imbajin imbajin mentioned this pull request May 11, 2023
Closed
27 tasks
imbajin
imbajin reviewed May 11, 2023
View reviewed changes
content/cn/docs/clients/restful-api/schema.md Outdated Show resolved Hide resolved
content/cn/docs/clients/restful-api/schema.md Outdated Show resolved Hide resolved
content/en/docs/clients/restful-api/schema.md Outdated Show resolved Hide resolved
@imbajin
Copy link
Member

imbajin commented May 11, 2023 •
edited
Loading

Also could fix it: (the mail should be [email protected], typo wrong in pic ⬇️)

image

TODO:

  • add add a "Easy to start" task ==> (add Wechat Picture in README for each repo, also in the website)

@liuxiaocs7
Copy link
Member Author

Also could fix it: (the mail should be [email protected], typo wrong in pic ⬇️)

image TODO:
  • add add a "Easy to start" task ==> (add Wechat Picture in README for each repo, also in the website)

Good idea, will be done in another seperate PR.

imbajin
imbajin approved these changes May 14, 2023
View reviewed changes
Copy link
Member

@imbajin imbajin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Have been tested it?)

@imbajin imbajin merged commit 9c794f6 into apache:master May 14, 2023
github-actions bot pushed a commit that referenced this pull request May 14, 2023
@imbajin
docs: modify and translate schema-api (#214)
0cdc561 
Update some outdated data info in example 9c794f6
@liuxiaocs7
Copy link
Member Author

LGTM (Have been tested it?)

yeap, local tests run fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imbajin imbajin imbajin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liuxiaocs7 @imbajin