Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix outdated hugegraph download link #211

Merged
merged 6 commits into from
May 9, 2023

Conversation

liuxiaocs7
Copy link
Member

@liuxiaocs7 liuxiaocs7 commented May 8, 2023

as title

the original url got 404 error, replace it with url from here

Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, I do remember there are several outdated download links like this.

Could you help to search for them in full-text and fix them together? In addition, the doc of the English directory (current is cn) also needs to be corrected

Also could add the basic instruction in hubble doc (visualize graph)

image

@liuxiaocs7
Copy link
Member Author

liuxiaocs7 commented May 8, 2023

Thanks a lot, I do remember there are several outdated download links like this.

Could you help to search for them in full-text and fix them together? In addition, the doc of the English directory (current is cn) also needs to be corrected

Also could add the basic instruction in hubble doc (visualize graph)

image

sure, i'm glad to do this!

now i deploy hugegraph and hubble by docker and try to run the loader demo

i'll add some basic instructions in hubble doc in next PR.


One question, When hubble creates a graph, we need to specify a name or id, but i don’t see the specified name or id in the loader demo. How to ensure that the data is imported into the specified graph?

schema.groovy defines vertex/edges/properties/index and struct.json as mapping file defines file format, etc.

image

@liuxiaocs7
Copy link
Member Author

Also i noticed that #447 modify the default UI, should we wait for the docker environment to take effect before modifying the screenshot.

dist/validate-release.sh Outdated Show resolved Hide resolved
@liuxiaocs7
Copy link
Member Author

Hi, @imbajin, i have fixed outdate links, But some locations are not sure, please help me to have a look, thanks!

@liuxiaocs7
Copy link
Member Author

Thanks a lot, I do remember there are several outdated download links like this.
Could you help to search for them in full-text and fix them together? In addition, the doc of the English directory (current is cn) also needs to be corrected
Also could add the basic instruction in hubble doc (visualize graph)
image

sure, i'm glad to do this!

now i deploy hugegraph and hubble by docker and try to run the loader demo

i'll add some basic instructions in hubble doc in next PR.

One question, When hubble creates a graph, we need to specify a name or id, but i don’t see the specified name or id in the loader demo. How to ensure that the data is imported into the specified graph?

schema.groovy defines vertex/edges/properties/index and struct.json as mapping file defines file format, etc.

image

find here:

image

image

@liuxiaocs7
Copy link
Member Author

seem works:

server ok

PS C:\Users\liuxiaocs> curl 192.168.34.164:18080


StatusCode        : 200
StatusDescription : OK
Content           : {"service":"hugegraph","version":"1.0.0","doc":"https://hugegraph.apache.org/docs/","api_doc":"https://hugegraph.apache.org/docs/clients/","apis":["auth","cyp
                    her","filter","graph","gremlin","job","met...
RawContent        : HTTP/1.1 200 OK
                    Content-Length: 270
                    Content-Type: application/json

                    {"service":"hugegraph","version":"1.0.0","doc":"https://hugegraph.apache.org/docs/","api_doc":"https://hugegraph.apache.org/docs...
Forms             : {}
Headers           : {[Content-Length, 270], [Content-Type, application/json]}
Images            : {}
InputFields       : {}
Links             : {}
ParsedHtml        : mshtml.HTMLDocumentClass
RawContentLength  : 270

create graph

image

insert data

bash bin/hugegraph-loader.sh -g hugegraph -p 18080 -f example/file/struct.json -s example/file/schema.groovy
[liuxiao@dev apache-hugegraph-loader-incubating-1.0.0]$ bash bin/hugegraph-loader.sh -g hugegraph -p 18080 -f example/file/struct.json -s example/file/schema.groovy
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/home/liuxiao/Code/hugegraph/apache-hugegraph-toolchain-incubating-1.0.0/apache-hugegraph-loader-incubating-1.0.0/lib/log4j-slf4j-impl-2.18.0.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/liuxiao/Code/hugegraph/apache-hugegraph-toolchain-incubating-1.0.0/apache-hugegraph-loader-incubating-1.0.0/lib/slf4j-log4j12-1.6.1.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http:https://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.apache.logging.slf4j.Log4jLoggerFactory]
>> HugeGraphLoader worked in NORMAL MODE
vertices/edges loaded this time : 8/6
--------------------------------------------------
count metrics
    input read success            : 14
    input read failure            : 0
    vertex parse success          : 8
    vertex parse failure          : 0
    vertex insert success         : 8
    vertex insert failure         : 0
    edge parse success            : 6
    edge parse failure            : 0
    edge insert success           : 6
    edge insert failure           : 0
--------------------------------------------------
meter metrics
    total time                    : 0.131s
    read time                     : 0.04s
    load time                     : 0.091s
    vertex load time              : 0.069s
    vertex load rate(vertices/s)  : 115
    edge load time                : 0.065s
    edge load rate(edges/s)       : 92

@imbajin
Copy link
Member

imbajin commented May 8, 2023

One question, When hubble creates a graph, we need to specify a name or id, but i don’t see the specified name or id in the loader demo. How to ensure that the data is imported into the specified graph?
schema.groovy defines vertex/edges/properties/index and struct.json as mapping file defines file format, etc.

Current loader doc is also too long to read (users may get lost in the page), it's not friendly and the doc should separate into multi subpages. (show the most important info for user first) [TODO]

Graph ID?

GraphID & GraphName is really confused for new users to set the proper value, also need enhance the description & the doc [TODO]

should we wait for the docker environment to take effect before modifying the screenshot.?

No need, the docker images could update anytime (currently it build once per week, we hope there is a way to auto build it when PR merged or enable a dockerhub hook)

i'll add some basic instructions in hubble doc in next PR.

fine

@liuxiaocs7
Copy link
Member Author

g.V() shows results that matchs, thanks!

image

@imbajin
Copy link
Member

imbajin commented May 8, 2023

g.V() shows results that matchs, thanks!

And we should also add a groovy script in hubble's doc so that users could add a graph with one-click paste & running (more friendly)

Just like the groovy example in server

separate in another pr

@liuxiaocs7 liuxiaocs7 changed the title fix hugegraph-loader download link fix outdated hugegraph download link May 9, 2023
@imbajin
Copy link
Member

imbajin commented May 9, 2023

also need revoke the url in validate-release doc (with svn url) [meet some network problems. so can't review or modify your code directly...]

image

@liuxiaocs7
Copy link
Member Author

also need revoke the url in validate-release doc (with svn url) [meet some network problems. so can't review or modify your code directly...]

image

got, fixed!

@@ -40,7 +40,7 @@ brew install wget
# 4. 下载 hugegraph-svn 目录 (版本号注意填写此次验证版本, 这里以1.0.0为例)
svn co https://dist.apache.org/repos/dist/dev/incubator/hugegraph/1.0.0/
# (注) 如果出现 svn 下载某个文件速度很慢的情况, 可以考虑 wget 单个文件下载, 如下 (或考虑使用 VPN / 代理)
wget https://dist.apache.org/repos/dist/dev/incubator/hugegraph/1.0.0/apache-hugegraph-toolchain-incubating-1.0.0.tar.gz
wget https://downloads.apache.org/incubator/hugegraph/1.0.0/apache-hugegraph-toolchain-incubating-1.0.0.tar.gz
Copy link
Member

@imbajin imbajin May 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need revert here (svn file could also be download by http mode)

@imbajin imbajin merged commit 50c327d into apache:master May 9, 2023
1 check passed
github-actions bot pushed a commit that referenced this pull request May 9, 2023
* fix hugegraph-loader download link
---------

Co-authored-by: imbajin <[email protected]> 50c327d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants