Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable hugo action to build site automaticly #148

Merged
merged 6 commits into from
Sep 15, 2022

Conversation

damonxue
Copy link
Contributor

I read the gohugo.io's doc, and compare the Apache ShenYu deploy.yml. The confusing discussion[1] was clear. But this action could not set up to my repository, because the settings > pages could not work exactly.

Pls review, and test.

[1] : #147

@damonxue damonxue changed the title [action] Hugo yml damonxue [action] Hugo yml action Sep 12, 2022
@imbajin imbajin linked an issue Sep 13, 2022 that may be closed by this pull request
@imbajin
Copy link
Member

imbajin commented Sep 13, 2022

But this action could not set up to my repository, because the settings > pages could not work exactly.

Seems we need a way to test it first (otherwise we could't ensure if it could run well), I'll try to checkout a new branch
based on yours to test it soon, thanks for your feedback

BTW, the action should run well in personal repository, if u want to dig it out, u can paste the error/problem here 😄~

@imbajin
Copy link
Member

imbajin commented Sep 13, 2022

Update: seems the action is running, but it skip the Deploy step:
image

The pipeline looks fine~

@imbajin imbajin changed the title [action] Hugo yml action chore: enable hugo action to build site automaticly Sep 13, 2022
.github/workflows/hugo.yml Outdated Show resolved Hide resolved
.github/workflows/hugo.yml Outdated Show resolved Hide resolved
@imbajin
Copy link
Member

imbajin commented Sep 14, 2022

add a new branch test-build in repository, and change the deploy logic to enable the last step (get error):
image

@damonxue
Copy link
Contributor Author

damonxue commented Sep 14, 2022

Permission deny to GitHub-bot.☺️

We can ask for help from [email protected] who makes shenyu-website success.

@imbajin
Copy link
Member

imbajin commented Sep 14, 2022

Permission deny to GitHub-bot.☺️

We can ask for help from [email protected] who makes shenyu-website success.

Thanks, but I got the reason in github action's official doc already (we need set the content permission to write)

After update it in test-build branch, it push well now (u can see it in asf-site branch)

image

@damonxue
Copy link
Contributor Author

Nice.

@imbajin
Copy link
Member

imbajin commented Sep 14, 2022

Enable keep_files to keep .asf.yaml in asf-site branch to flush the website cache immediately (IMPORTANT)

Now the pipeline is fine.

And I refactor some steps to make them clearly, you could check it again (If u check it OK, I'll merge this PR to master), thanks

@imbajin imbajin merged commit b63473e into apache:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto build & publish the pages after the PR merged
2 participants