Skip to content

Commit

Permalink
remove useless disclaim file (#179)
Browse files Browse the repository at this point in the history
  • Loading branch information
@imbajin
imbajin committed Jan 7, 2023
1 parent edaf2c2 commit 675a07e
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 26 deletions.
27 changes: 13 additions & 14 deletions content/cn/docs/contribution-guidelines/validate-release.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ gpg --version

# 3. 下载 hugegraph-svn 目录 (版本号注意填写此次验证版本, 这里以1.0.0为例)
svn co https://dist.apache.org/repos/dist/dev/incubator/hugegraph/1.0.0/
# (注) 如果出现 svn 下载某个文件速度很慢的情况, 可以考虑 wget 单个文件下载, 如下 (或考虑使用代理)
# (注) 如果出现 svn 下载某个文件速度很慢的情况, 可以考虑 wget 单个文件下载, 如下 (或考虑使用 VPN / 代理)
wget https://dist.apache.org/repos/dist/dev/incubator/hugegraph/1.0.0/apache-hugegraph-toolchain-incubating-1.0.0.tar.gz
```

Expand Down Expand Up @@ -72,11 +72,11 @@ Do you really want to set this key to ultimate trust? (y/N) y #选择y, 然后 q

# 3. 检查签名(确保没有 Warning 输出, 每一个 source/binary 文件都提示 Good Signature)
#单个文件验证
gpg --verify xx.asc xxx-source.tar.gz
gpg --verify xx.asc xxx-binary.tar.gz # 注: 我们目前没有 binary 后缀
#for循环遍历验证(推荐使用)
for i in *.tar.gz; do echo $i; gpg --verify $i.asc $i ; done
gpg --verify xx.asc xxx-src.tar.gz
gpg --verify xx.asc xxx.tar.gz # 注：目前没有 bin/binary 后缀

# 一行脚本快速验证所有包 (推荐使用，请确保所有 gpg 公钥已经信任)
for i in *.tar.gz; do echo $i; gpg --verify $i.asc $i ; done
```

先确认了整体的"完整性 + 一致性", 然后接下来确认具体的内容 (**关键**)
Expand All @@ -89,16 +89,15 @@ for i in *.tar.gz; do echo $i; gpg --verify $i.asc $i ; done

##### A. 源码包

解压 `xxx-hugegraph-source.tar.gz`后, 进行如下检查:
解压 `*hugegraph*src.tar.gz`后, 进行如下检查:

1. 文件夹都带有 `incubating`, 且不存在**空的**文件/文件夹
2. 存在`DISCLAIMER`文件
3. 存在 `LICENSE` + `NOTICE` 文件并且内容正常
4. **不存在**任何二进制文件
5. 源码文件都包含标准 `ASF License` 头 (这个用插件跑一下为主)
6. 检查每个父/子模块的 `pom.xml` 版本号是否一致 (且符合期望)
7. 检查前 3 ~ 5 个 commit 提交, 点进去看看是否修改处和源码文件一致
8. 最后, 确保源码可以正常/正确编译 (然后看看测试和规范)
2. 存在 `LICENSE` + `NOTICE` + 存在 `DISCLAIMER` 文件并且内容正常
3. **不存在** 缺乏 License 的二进制文件
4. 源码文件都包含标准 `ASF License` 头 (这个用插件跑一下为主)
5. 检查每个父 / 子模块的 `pom.xml` 版本号是否一致 (且符合期望)
6. 检查前 3 ~ 5 个 commit 提交，点进去看看是否修改处和源码文件一致
7. 最后，确保源码可以正常 / 正确编译 (然后看看测试和规范)

```bash
# 请优先使用/切换到 java 11 版本进行后序的编译和运行操作
Expand Down Expand Up @@ -136,7 +135,7 @@ bin/start-computer.sh -d local -r master
#### 5. 检查官网以及 github 等页面

1. 确保官网至少满足 [apache website check](https://whimsy.apache.org/pods/project/hugegraph), 以及没有死链等
2. 更新**下载链接**以及版本更新说明
2. 更新**下载链接**存在, 以及版本更新说明页面更新
3. ...

## 邮件模板
Expand Down
24 changes: 12 additions & 12 deletions content/en/docs/contribution-guidelines/validate-release.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,10 @@ Do you really want to set this key to ultimate trust? (y/N) y #slect y, then q q

# 3. Check the signature (make sure there is no Warning output, every source/binary file prompts Good Signature)
#Single file verification
gpg --verify xx.asc xxx-source.tar.gz
gpg --verify xx.asc xxx-binary.tar.gz # 注: 我们目前没有 binary 后缀
#for loop traversal verification (recommended)
gpg --verify xx.asc xxx-src.tar.gz
gpg --verify xx.asc xxx.tar.gz # Note: without the bin/binary suffix

# One-click shell traversal verification (recommended)
for i in *.tar.gz; do echo $i; gpg --verify $i.asc $i ; done

```
Expand All @@ -88,16 +89,15 @@ First of all, we need to download the package from the apache official `release-

##### A. source package

After decompressing `xxx-hugegraph-source.tar.gz`, Do the following checks:
After decompressing `*hugegraph*src.tar.gz`, Do the following checks:

1. folders with `incubating`, and no **empty** files/folders
2. `DISCLAIMER` file exists
3. `LICENSE` + `NOTICE` file exists and the content is normal
4. ** does not exist ** any binaries
5. The source code files all contain the standard `ASF License` header ((this can be done using a plugin))
6. Check whether the `pom.xml` version number of each parent/child module is consistent (and meet expectations)
7. Check the first 3 to 5 commits, click to see if the modification is consistent with the source file
8. Finally, make sure the source code works/compiles correctly (then look at tests and specs)
2. `LICENSE` + `NOTICE` + `DISCLAIM` file exists and the content is normal
3. **does not exist** binaries (without LICENSE)
4. The source code files all contain the standard `ASF License` header (this could be done with the Maven-MAT plugin)
5. Check whether the `pom.xml` version number of each parent/child module is consistent (and meet expectations)
6. Check the first 3 to 5 commits, click to see if the modification is consistent with the source file
7. Finally, make sure the source code works/compiles correctly

```bash
# prefer to use/switch to java 11 for the following operations (compiling/running)
Expand Down Expand Up @@ -135,7 +135,7 @@ more reference official website: https://hugegraph.apache.org/cn/docs/quickstart
#### 5. Check the official website and GitHub and other pages

1. Make sure that the official website at least meets [apache website check](https://whimsy.apache.org/pods/project/hugegraph), and no circular links etc.
2. Update **download link** and version update instructions
2. Update **download link** and release notes updated
3. ...

## Mail Template
Expand Down

0 comments on commit 675a07e

Please sign in to comment.