[VL] Ensure sed pattern can be matched when modifying velox setup scripts #6505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
@yma11, could you take a look? |
rui-mo
approved these changes
Jul 19, 2024
|
Let's merge this one firstly. If some issue is found, please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
sed doesn't report error if given pattern is not matched. It's possible our expected changes are not applied to velox setup script due to upstream's code change. Here, simply run grep command to ensure pattern matched.
Only do the check for setup-ubuntu.sh, since other scripts like setup-centos7.sh, setup-centos8.sh are not maintained in upstream velox now.
How was this patch tested?
CI/local.
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)