Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLUTEN-5341] fix fail 3.5 ut of VeloxParquetWriteSuite #5463

Merged
merged 6 commits into from
Apr 22, 2024
Merged

[GLUTEN-5341] fix fail 3.5 ut of VeloxParquetWriteSuite #5463

merged 6 commits into from
Apr 22, 2024

Conversation

gaoyangxiaozhu
Copy link
Contributor

What changes were proposed in this pull request?

fix test write parquet with compression codec ut of VeloxParquetWriteSuite

(Fixes: #5341)

How was this patch tested?

manually run

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@gaoyangxiaozhu gaoyangxiaozhu changed the title [GLUTEN-5341] [Part 2] fix fail 3.5 ut of VeloxParquetWriteSuite [GLUTEN-5341] fix fail 3.5 ut of VeloxParquetWriteSuite Apr 19, 2024
@github-actions GitHub Actions
Copy link

#5341

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@gaoyangxiaozhu
Copy link
Contributor Author

@yma11 / @zhouyuan for help sign

@zhouyuan
Copy link
Contributor

CC @JkSelf

JkSelf
JkSelf approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@JkSelf JkSelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@zhli1142015 zhli1142015 merged commit d566aac into apache:main Apr 22, 2024
39 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_5463_time.csv log/native_master_04_21_2024_b08258e51_time.csv difference percentage
q1 36.30 34.90 -1.401 96.14%
q2 23.90 24.06 0.160 100.67%
q3 37.80 36.70 -1.104 97.08%
q4 39.18 40.96 1.782 104.55%
q5 71.82 69.60 -2.222 96.91%
q6 7.01 7.44 0.436 106.22%
q7 83.42 85.59 2.167 102.60%
q8 85.81 85.37 -0.436 99.49%
q9 121.92 125.78 3.863 103.17%
q10 47.42 43.35 -4.067 91.42%
q11 20.77 19.84 -0.928 95.53%
q12 27.28 25.80 -1.476 94.59%
q13 55.81 54.10 -1.706 96.94%
q14 17.79 21.91 4.123 123.17%
q15 29.52 29.24 -0.277 99.06%
q16 14.54 14.28 -0.254 98.26%
q17 102.46 101.35 -1.112 98.91%
q18 141.93 145.10 3.163 102.23%
q19 15.68 13.61 -2.069 86.80%
q20 27.83 28.46 0.627 102.25%
q21 296.18 287.28 -8.901 96.99%
q22 16.20 14.78 -1.420 91.24%
total 1320.57 1309.52 -11.051 99.16%

Preetesh2110 pushed a commit to Preetesh2110/incubator-gluten that referenced this pull request Apr 25, 2024
@gaoyangxiaozhu @Preetesh2110
[GLUTEN-5341] fix fail 3.5 ut of VeloxParquetWriteSuite (apache#5463)
425dba2 
[GLUTEN-5341] fix fail 3.5 ut of  VeloxParquetWriteSuite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yma11 yma11 yma11 left review comments

@JkSelf JkSelf JkSelf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UT failures for Spark3.5
6 participants
@gaoyangxiaozhu @zhouyuan @GlutenPerfBot @yma11 @JkSelf @zhli1142015