Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Windows batch enhancement #4100

Closed
nadment opened this issue Jul 1, 2024 · 0 comments · Fixed by #4101
Closed

[Task]: Windows batch enhancement #4100

nadment opened this issue Jul 1, 2024 · 0 comments · Fixed by #4101
Assignees
@nadment
Labels
Hop Run P3 Nice to have task
Milestone
2.10

Comments

@nadment
Copy link
Contributor

nadment commented Jul 1, 2024

What needs to happen?

  1. If the "hop-run.bat" command is to be run from an external program, the last line of the batch should be the launch of the JVM and its parameters so that the return code of the execution can be returned from the batch.

image

  1. The first "echo off" should be replace with "@echo off"

Issue Priority

Priority: 3

Issue Component

Component: Hop Run
@nadment nadment added the task label Jul 1, 2024
@nadment nadment self-assigned this Jul 1, 2024
@github-actions github-actions bot added P3 Nice to have Hop Run labels Jul 1, 2024
nadment added a commit to nadment/hop that referenced this issue Jul 1, 2024
@nadment
hop-run.bat enhancement apache#4100
8654767
nadment added a commit to nadment/hop that referenced this issue Jul 1, 2024
@nadment
Windows batch enhancement apache#4100
304fd33
@nadment nadment changed the title [Task]: hop-run.bat enhancement [Task]: Windows batch enhancement Jul 1, 2024
@nadment nadment linked a pull request Jul 1, 2024 that will close this issue
Windows batch enhancement #4100 #4101
Merged
hansva added a commit that referenced this issue Jul 2, 2024
@hansva
Merge pull request #4101 from nadment/4100
0689971 
Windows batch enhancement #4100
@hansva hansva added this to the 2.10 milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadment nadment

Labels
Hop Run P3 Nice to have task
Projects
None yet
Milestone
2.10
Development

Successfully merging a pull request may close this issue.

Windows batch enhancement #4100 nadment/hop
2 participants
@hansva @nadment