Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-23964: SemanticException in query 30 while generating logical plan #5373

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

kasakrisz
Copy link
Contributor

What changes were proposed in this pull request?

  • Enable query30.q and cbo_query30.q.
  • Change column references c_last_review_date to c_last_review_date_sk
  • add golden files.

Why are the changes needed?

TPC-DS schame changed.

Does this PR introduce any user-facing change?

No

Is the change a dependency upgrade?

No.

How was this patch tested?

mvn test -Dtest.output.overwrite -Dtest=TestTezTPCDS30TBPerfCliDriver -Dqfile=query30.q,cbo_query30.q -pl itests/qtest -Pitests

Copy link
Contributor

@zabetak zabetak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending tests!

Copy link

sonarcloud bot commented Jul 29, 2024

@kasakrisz kasakrisz merged commit 929305f into apache:master Jul 30, 2024
6 checks passed
@kasakrisz kasakrisz deleted the HIVE-23964-master-q30 branch July 30, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants