Added the function of sending SMS messages through Alibaba Cloud. #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomsun28
reviewed
Apr 18, 2024
Comment on lines
247
to
249
| /** | ||
| * 阿里云账户访问密钥id | ||
| */ |
There was a problem hiding this comment.
👍 hi, please use the english describe.
There was a problem hiding this comment.
Should all the descriptions inside be written in English?
|
please add the apache header in files |
tomsun28
reviewed
Apr 18, 2024
|
|
||
| /** | ||
| * sms service client for aliyun cloud | ||
| * @author lwq |
There was a problem hiding this comment.
Suggested change
| * @author lwq |
hi, we will not add author in file header.
tomsun28
reviewed
Apr 18, 2024
| import com.fasterxml.jackson.databind.ObjectMapper; | ||
|
|
||
| import java.util.Map; | ||
|
|
There was a problem hiding this comment.
please add head describe here
tomsun28
reviewed
Apr 18, 2024
| import java.util.ResourceBundle; | ||
|
|
||
| /** | ||
| * @author lwq |
There was a problem hiding this comment.
Suggested change
| * @author lwq | |
| * alicloud alarm handler implment |
tomsun28
reviewed
Apr 18, 2024
| req.setPhoneNumberSet(phones); | ||
| try { | ||
| Map<String, Object> param = new HashMap<>(); | ||
| //taskName：监控名称alert：告警级别 message：告警信息 sysTime：系统时间 |
There was a problem hiding this comment.
Suggested change
| //taskName：监控名称alert：告警级别 message：告警信息 sysTime：系统时间 | |
| // taskName: monitoring name, alert: alarm level, message: alarm content, sysTime:system time |
tomsun28
reviewed
Apr 18, 2024
|
|
||
| @Override | ||
| public void send(NoticeReceiver receiver, NoticeTemplate noticeTemplate, Alert alert) { | ||
| // SMS notification 短信通知 |
There was a problem hiding this comment.
Suggested change
| // SMS notification 短信通知 | |
| // SMS notification |
There was a problem hiding this comment.
Thanks for your guidance.
tomsun28
reviewed
Apr 18, 2024
|
Hi, please fix them above, we have style check for codes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Checklist
Add or update API