HBASE-28396: Quota throttling can cause a leak of scanners #6055
+264
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
I don't think the build failure is related to my change |
|
Just ignore the Hadoop 3.4.0 Hadoop check failure. The branch itself is broken. |
|
I'm working on adding a test at the moment that will sanity check the scanner counts |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
hgromer
commented
Aug 29, 2024
| @@ -216,7 +216,7 @@ public String getName() { | |||
| } | |||
|
|
|||
| /** This class tracks a single Lease. */ | |||
| static class Lease implements Delayed { | |||
| protected static class Lease implements Delayed { | |||
There was a problem hiding this comment.
Not sure if there's a better way to do this, but I needed to expose this to implement this method to track the leases created
hgromer
commented
Aug 29, 2024
| public void itIncreasesScannerCount() throws Exception { | ||
| long beforeScan = countLeases(); | ||
| ResultScanner scanner = TABLE.getScanner(new Scan()); | ||
| Thread.sleep(1000); |
There was a problem hiding this comment.
We need to wait until the scan and lease are created server-side. Otherwise, our lease counting will not reflect this new scan that was created
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've noticed memory issues during intense periods of quota throttling. This happens because new scanners are created prior to the acquisition of the throttle, and aren't cleaned up correctly in the case acquiring the throttle throws an exception. This change creates a new region scanner only if the quota was acquired successfully to avoid scanner leaks.