HADOOP-18060.RPCMetrics increases the number of handlers in processing. #3822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here are some data that has been verified. |
virajjasani
reviewed
Dec 22, 2021
| @@ -498,6 +498,7 @@ protected ResponseBuffer initialValue() { | |||
| private Map<Integer, Listener> auxiliaryListenerMap; | |||
| private Responder responder = null; | |||
| private Handler[] handlers = null; | |||
| final private AtomicInteger numInProcessHandler = new AtomicInteger(); | |||
Comment on lines
3068
to
3074
| private enum HandlerStatus { | ||
| /**Working for a Call.*/ | ||
| IN_PROCESS, | ||
|
|
||
| /**Idle state, waiting for a new call.*/ | ||
| IN_IDLE | ||
| } |
There was a problem hiding this comment.
Do we need this enum? We are updating the status to either IN_PROCESS or IN_IDLE but not really exposing it anywhere.
| assertEquals(rpcMetrics.getNumInProcessHandler(), 0); | ||
|
|
||
| ExternalCall<String> call1 = newExtCall(ugi, | ||
| new PrivilegedExceptionAction<String>() { |
| } | ||
| }); | ||
| ExternalCall<Void> call2 = newExtCall(ugi, | ||
| new PrivilegedExceptionAction<Void>() { |
There was a problem hiding this comment.
same as above, lambda and assertEquals for exact comparison
| new PrivilegedExceptionAction<String>() { | ||
| @Override | ||
| public String run() throws Exception { | ||
| assertTrue(rpcMetrics.getNumInProcessHandler() > 0); |
There was a problem hiding this comment.
How about exact comparison? We can use assertEquals(1, rpcMetrics.getNumInProcessHandler())
There was a problem hiding this comment.
Thank you @virajjasani for your comments and reviews.
I will update it later.
|
💔 -1 overall
This message was automatically generated. |
93c168d
to
9f4fb72
Compare
|
💔 -1 overall
This message was automatically generated. |
|
Thank you very much @virajjasani . |
ayushtkn
reviewed
Dec 23, 2021
There was a problem hiding this comment.
Had a cursory look:
In case of Observer reads, if the namenode state is lower than that of the client. We would reQueue the call, and reattempt. Will this numInProcessHandler not keep on increasing in that case?
Can you double check, I couldn't dig in further...
// Re-queue the call and continue
requeueCall(call);
call = null;
continue;
|
Thanks @ayushtkn for the comment and review. |
ayushtkn
approved these changes
Dec 23, 2021
|
Thank you @jianghuazhu for your patch. Would you update Metrics.md as well to reflect the new metric to the document? |
|
Thank you @aajisaka for your comments and reviews. |
9f4fb72
to
703e6f3
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
I have updated some, can you please review this pr again, @aajisaka . |
tomscut
approved these changes
Dec 28, 2021
|
I updated it again. Move the theme to the Hadoop-common project. |
|
Thanks @jianghuazhu for your update. LGTM. |
|
@jianghuazhu Thanks for your contribution. @aajisaka @ayushtkn @tomscut Thanks for your reviews! Merged |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Now we can't see how many Handlers in RPC are actually being used. It would be very helpful to see this information directly through RPCMetrics.
The purpose of this pr is to solve this problem.
Details: HDFS-16394
How was this patch tested?
This needs to be tested.
When accessing RPC, you need to know how many handlers are being used based on RPCMetrics.