-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18214. Update BUILDING.txt #3811
Conversation
java-8-openjdk become openjdk-8-jdk (see both ubuntu and debian package's name)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't actually try on a ubuntu box. But found a page, which mentions the same command
https://docs.datastax.com/en/jdk-install/doc/jdk-install/installOpenJdkDeb.html
@@ -57,7 +57,7 @@ Refer to dev-support/docker/Dockerfile): | |||
|
|||
* Open JDK 1.8 | |||
$ sudo apt-get update | |||
$ sudo apt-get -y install java-8-openjdk | |||
$ sudo apt-get -y install openjdk-8-jdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is in fact the package we use in the Dockerfile build script. https://github.com/apache/hadoop/blob/trunk/dev-support/docker/pkg-resolver/packages.json#L264
I merged this PR. But it would be nice to create an Apache JIRA next time. |
I will create that jira before i cherrypick to branch3.3 |
java-8-openjdk become openjdk-8-jdk (see both ubuntu and debian package's name) Contributed by Giovambattista Vieri Reviewed-by: Ayush Saxena <[email protected]> Change-Id: I63b2bbfdd575cf56d20cd6c8fff33a70cadda7f2
java-8-openjdk become openjdk-8-jdk (see both ubuntu and debian package's name) Contributed by Giovambattista Vieri Reviewed-by: Ayush Saxena <[email protected]> Change-Id: I63b2bbfdd575cf56d20cd6c8fff33a70cadda7f2
created https://issues.apache.org/jira/browse/HADOOP-18214 for this; cherrypicked with that jira in the title to branch 3.3.3 and 3.3 |
Hi @gvieri, thank you for your contribution! Could you let me know your ASF JIRA account? I want to set you as the assignee of https://issues.apache.org/jira/browse/HADOOP-18214 |
It is necessary to have ASF JIRA account ? |
@gvieri well yes. This one got committed initially without a Jira since it wasn’t changing the core code, but in general we tend to have jira for almost everything. That’s how we track issues. BTW. If you have a Jira account and have it assigned on your name. You will get the credit in the Release Notes as well when Hadoop does the release. Just one of the things if that interests or motivates you :-) |
java-8-openjdk become openjdk-8-jdk (see both ubuntu and debian package's name) Reviewed-by: Ayush Saxena <[email protected]>
Description of PR
java-8-openjdk become openjdk-8-jdk (see both ubuntu and debian package's name)
How was this patch tested?
with simple command issued on command line
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?