Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-18214. Update BUILDING.txt #3811

Merged
merged 1 commit into from
Dec 22, 2021
Merged

HADOOP-18214. Update BUILDING.txt #3811

merged 1 commit into from
Dec 22, 2021

Conversation

gvieri
Copy link
Contributor

@gvieri gvieri commented Dec 16, 2021

Description of PR

java-8-openjdk become openjdk-8-jdk (see both ubuntu and debian package's name)

How was this patch tested?

with simple command issued on command line

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

java-8-openjdk become openjdk-8-jdk (see both ubuntu and debian package's name)
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't actually try on a ubuntu box. But found a page, which mentions the same command
https://docs.datastax.com/en/jdk-install/doc/jdk-install/installOpenJdkDeb.html

@@ -57,7 +57,7 @@ Refer to dev-support/docker/Dockerfile):

* Open JDK 1.8
$ sudo apt-get update
$ sudo apt-get -y install java-8-openjdk
$ sudo apt-get -y install openjdk-8-jdk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jojochuang jojochuang merged commit 97ed029 into apache:trunk Dec 22, 2021
@jojochuang
Copy link
Contributor

I merged this PR. But it would be nice to create an Apache JIRA next time.

@steveloughran
Copy link
Contributor

I will create that jira before i cherrypick to branch3.3

@steveloughran steveloughran changed the title Update BUILDING.txt HADOOP-18214. Update BUILDING.txt Apr 21, 2022
asfgit pushed a commit that referenced this pull request Apr 21, 2022
java-8-openjdk become openjdk-8-jdk (see both ubuntu and debian package's name)

Contributed by Giovambattista Vieri
Reviewed-by: Ayush Saxena <[email protected]>

Change-Id: I63b2bbfdd575cf56d20cd6c8fff33a70cadda7f2
asfgit pushed a commit that referenced this pull request Apr 21, 2022
java-8-openjdk become openjdk-8-jdk (see both ubuntu and debian package's name)

Contributed by Giovambattista Vieri
Reviewed-by: Ayush Saxena <[email protected]>

Change-Id: I63b2bbfdd575cf56d20cd6c8fff33a70cadda7f2
@apache apache deleted a comment from hadoop-yetus Apr 21, 2022
@steveloughran
Copy link
Contributor

created https://issues.apache.org/jira/browse/HADOOP-18214 for this; cherrypicked with that jira in the title to branch 3.3.3 and 3.3

@aajisaka
Copy link
Member

aajisaka commented Apr 22, 2022

Hi @gvieri, thank you for your contribution!

Could you let me know your ASF JIRA account? I want to set you as the assignee of https://issues.apache.org/jira/browse/HADOOP-18214

@gvieri
Copy link
Contributor Author

gvieri commented Apr 28, 2022

It is necessary to have ASF JIRA account ?

@ayushtkn
Copy link
Member

@gvieri well yes. This one got committed initially without a Jira since it wasn’t changing the core code, but in general we tend to have jira for almost everything. That’s how we track issues.

BTW. If you have a Jira account and have it assigned on your name. You will get the credit in the Release Notes as well when Hadoop does the release. Just one of the things if that interests or motivates you :-)

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
java-8-openjdk become openjdk-8-jdk (see both ubuntu and debian package's name)

Reviewed-by: Ayush Saxena <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants