Update GrapeIvy.groovy: set ivyInstance to IvyContext, for speed up #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When custom grape.config is present(-Dgrape.config=...), there are no need load default ivysettings! if you want see the diff,run with -Dgrape.config=... and -Divy.message.logger.level=4
|
@paulk-asert As you are the grape expert, what's your opinion? |
|
hoping to get time to look soon |
|
@paulk-asert All tests pass, I guess this is safe to merge into master? |
|
We won't have any tests covering this. I suspect it is safe to merge - just doing some checking. I think it applies all the time, not just when a custom config is specified via |
|
I did further testing and everything seems to be working well. Thanks for spotting this! I will close this once I create a Jira ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When custom grape.config is present(-Dgrape.config=...), there are no need load default ivysettings!
if you want see the diff,run with -Dgrape.config=... and -Divy.message.logger.level=4
groovy/groovy-core#665