Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix][docs] wrong method name in state-processor-api example #9520

Closed

Conversation

alpinegizmo
Copy link
Contributor

What is the purpose of the change

The State Processor API docs have an example of implementing a KeyedStateReaderFunction. The wrong method name is used in this example -- the class has no processKey method, but rather a readKey method.

Verifying this change

This change is a trivial typo fix.

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 23, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit b30983f (Mon Aug 26 08:25:25 UTC 2019)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 23, 2019

CI report:

@1u0
Copy link
Contributor

1u0 commented Aug 23, 2019

@flinkbot run travis

@StephanEwen
Copy link
Contributor

Thank you for the fixing this!

Looks good, merging...

StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Aug 23, 2019
@asfgit asfgit closed this in a55dc42 Aug 26, 2019
StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Aug 26, 2019
asfgit pushed a commit that referenced this pull request Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants