Disable POJO types #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 8, 2014 11:20
There are various issues when working with POJOs in the Java API, for example [1]. [1] https://mail-archives.apache.org/mod_mbox/incubator-flink-dev/201407.mbox/%3C53D96049.1060509%40cse.uta.edu%3E
PackagedProgramEndToEndITCase used a KMeans variant, which relies on expression keys to select the field to group on. This commit replaces this with a key selector.
Disables WordCountPOJOITCase, which executes the WordCountPOJO example. The example code is still included with the source code (with notice that it is currently not working), but will *not* be packaged as a JAR anymore.
|
Yes, this should disable it completely. |
|
OK. Travis does not produce any problems any more as well. I will wait for the last Travis VMs to finish and then will merge it. |
asfgit
pushed a commit
that referenced
this pull request
Aug 8, 2014
There are various issues when working with POJOs in the Java API, for example [1]. This commit squashes the following commmits: 1. Disable tests, which depend on POJO types 2. Replace expression keys with key selector in test 3. PackagedProgramEndToEndITCase used a KMeans variant, which relies on expression keys to select the field to group on. This commit replaces this with a key selector. 4. Disable WordCountPOJO test case and package 5. Disables WordCountPOJOITCase, which executes the WordCountPOJO example. The example code is still included with the source code (with notice that it is currently not working), but will *not* be packaged as a JAR anymore. 6. Disable tests, which depend on POJO types (continued) [1] https://mail-archives.apache.org/mod_mbox/incubator-flink-dev/201407.mbox/%3C53D96049.1060509%40cse.uta.edu%3E This closes #93.
|
I think it would be a good idea to comment out the expression key methods. |
|
I agree. I didn't think of this 😮 |
|
Fixed in b63beba. |
tzulitai
pushed a commit
to tzulitai/flink
that referenced
this pull request
Jan 15, 2021
…e module configurations This closes apache#93.
stgztsw
pushed a commit
to stgztsw/flink
that referenced
this pull request
Apr 12, 2022
change the logic of getting orc column count in DFSUtil.java
jnh5y
added a commit
to jnh5y/flink
that referenced
this pull request
Dec 18, 2023
* [SQL-1035] Couple SQL Service tasks with Flink version * Fixing checkstyle. --------- Co-authored-by: Jim Hughes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@StephanEwen, @aljoscha: Can someone please confirm that this is the place to disable the POJO types?
There are various issues when working with POJOs in the Java API, for example [1].
[1] https://mail-archives.apache.org/mod_mbox/incubator-flink-dev/201407.mbox/%3C53D96049.1060509%40cse.uta.edu%3E