-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-13118][jdbc] Introduce JDBC table factory and bridge JDBC table source with streaming table source #9029
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 1fee3fb (Tue Aug 06 15:40:27 UTC 2019) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tsreaper for your nice code~ Left some comments.
...s/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCTableSourceSinkFactory.java
Outdated
Show resolved
Hide resolved
...s/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCTableSourceSinkFactory.java
Outdated
Show resolved
Hide resolved
...s/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCTableSourceSinkFactory.java
Outdated
Show resolved
Hide resolved
...nnectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/dialect/JDBCDialect.java
Outdated
Show resolved
Hide resolved
...s/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCTableSourceSinkFactory.java
Outdated
Show resolved
Hide resolved
...s/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCTableSourceSinkFactory.java
Outdated
Show resolved
Hide resolved
...s/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCTableSourceSinkFactory.java
Outdated
Show resolved
Hide resolved
...s/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCTableSourceSinkFactory.java
Outdated
Show resolved
Hide resolved
...k-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCTableSource.java
Outdated
Show resolved
Hide resolved
...s/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCTableSourceSinkFactory.java
Outdated
Show resolved
Hide resolved
...k-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCTableSource.java
Show resolved
Hide resolved
...k-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCTableSourceSinkFactoryITCase.java
Outdated
Show resolved
Hide resolved
...s/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCTableSourceSinkFactory.java
Outdated
Show resolved
Hide resolved
@wuchong do you need to take a look at the property api? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tsreaper , I left some comments.
...k-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCTableSource.java
Show resolved
Hide resolved
...k-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCTableSource.java
Outdated
Show resolved
Hide resolved
...k-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCTableSource.java
Outdated
Show resolved
Hide resolved
...k-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCTableSource.java
Outdated
Show resolved
Hide resolved
...k-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCTableSource.java
Outdated
Show resolved
Hide resolved
...s/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCTableSourceSinkFactory.java
Outdated
Show resolved
Hide resolved
...s/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCTableSourceSinkFactory.java
Outdated
Show resolved
Hide resolved
flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCTestBase.java
Outdated
Show resolved
Hide resolved
...k-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCTableSourceSinkFactoryITCase.java
Outdated
Show resolved
Hide resolved
...k-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCTableSourceSinkFactoryITCase.java
Outdated
Show resolved
Hide resolved
...k-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCTableSource.java
Outdated
Show resolved
Hide resolved
...s/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCTableSourceSinkFactory.java
Outdated
Show resolved
Hide resolved
...s/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCTableSourceSinkFactory.java
Outdated
Show resolved
Hide resolved
...k-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCTableSource.java
Show resolved
Hide resolved
...k-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCTableSource.java
Outdated
Show resolved
Hide resolved
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/table/descriptors/JDBCValidator.java
Show resolved
Hide resolved
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/table/descriptors/JDBCValidator.java
Outdated
Show resolved
Hide resolved
flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCTestBase.java
Outdated
Show resolved
Hide resolved
flink-core/src/main/java/org/apache/flink/configuration/TimeLength.java
Outdated
Show resolved
Hide resolved
flink-core/src/test/java/org/apache/flink/configuration/TimeLengthTest.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/flink/api/java/io/jdbc/split/NumericBetweenParametersProvider.java
Show resolved
Hide resolved
...k-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCScanOptions.java
Outdated
Show resolved
Hide resolved
...k-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCScanOptions.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the effort @tsreaper .
+1
…e source with streaming table source This closes apache#9029
…e source with streaming table source
…e source with streaming table source This closes apache#9029
Travis passed. https://travis-ci.org/wuchong/flink/builds/557371490 |
What is the purpose of the change
Currently
JDBCTableSource
only implements theLookupableTableSource
interface and can only be used as a look-up table source. This PR bridges the table source with theStreamTableSource
andProjectableTableSource
interfaces so thatJDBCTableSource
can also be used as a scan table source.To create a proper jdbc table source and sink, this PR also introduces a
JDBCTableSourceSinkFactory
to create the sources and sinks according to the properties specified by users.Brief change log
StreamTableSource
andProjectableTableSource
interfaces onJDBCTableSource
.JDBCTableSourceSinkFactory
.Verifying this change
This change is covered by new IT cases (
JDBCTableSourceSinkFactoryITCase
).Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation