[FLINK-12254][table] Update value literals to new type system #8581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
dawidwys
approved these changes
Jun 5, 2019
| * instances must strictly adhere to the schema defined by the type info. | ||
| * | ||
| * @param fieldNames array of field names | ||
| * @param types array of field types |
There was a problem hiding this comment.
really nit: We could have the same description for types param as in Row(TypeInformation... types)
| * <p>Distinction between {@link BasicArrayTypeInfo} and {@link ObjectArrayTypeInfo}. | ||
| * <li>Let POJOs, case classes, and tuples pass through the planner.</li> | ||
| * | ||
| * <li>Inconsistent nullability. Most types are nullable even though type information does not support it.</li> |
| @@ -183,22 +183,22 @@ abstract class LogicalWindowAggregateRuleBase(description: String) | |||
| TumblingGroupWindow( | |||
| windowRef, | |||
| timeField, | |||
| new ValueLiteralExpression(interval, INTERVAL_MILLIS)) | |||
| new ValueLiteralExpression(interval, fromLegacyInfoToDataType(INTERVAL_MILLIS))) | |||
There was a problem hiding this comment.
How about just use DataTypes explicitly?
| return defaultMethod(valueLiteralExpression); | ||
| } | ||
| return ExpressionUtils.extractValue(valueLiteralExpression, Integer.class) | ||
| .map((i) -> Collections.singletonList(inputFieldReferences.get(i - 1))) |
There was a problem hiding this comment.
nit: unnecessary parenthesis around i.
|
Thank you @dawidwys. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR updates
ValueLiteralExpressionandnullOfto the new type system. All existing tests still pass.Additionally, it deprecates the old
Typesclasses that were providing type information.Brief change log
ValueLiteralExpressionreturnsDataTypenowTypesclass has been ported and is deprecated nowVerifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): yesDocumentation