Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-12539] [fs-connector] Make StreamingFileSink customizable #8469

Merged
merged 2 commits into from
May 22, 2019

Conversation

kailashhd
Copy link
Contributor

@kailashhd kailashhd commented May 16, 2019

What is the purpose of the change

Provide mechanisms to extend the StreamingFileSink class and make it customizable

Brief change log

  • Provide mechanisms to extend the StreamingFileSink class and make it customizable

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@kailashhd
Copy link
Contributor Author

cc @tweise @tillrohrmann Looks like I don't have permission to add you as reviewers on the PR itself.

@@ -170,7 +170,7 @@ private StreamingFileSink(
/**
* The base abstract class for the {@link RowFormatBuilder} and {@link BulkFormatBuilder}.
*/
private abstract static class BucketsBuilder<IN, BucketID> implements Serializable {
public abstract static class BucketsBuilder<IN, BucketID> implements Serializable {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be protected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. protected is better. Apologies.

@kailashhd
Copy link
Contributor Author

I am not sure what "Join list" means.

@tweise tweise changed the title [FLINK-12539][Connectors / FileSystem] StreamingFileSink: Make the class customizable [FLINK-12539] [fs-connector] Make StreamingFileSink customizable May 22, 2019
@tweise tweise merged commit 7748729 into apache:master May 22, 2019
@kailashhd kailashhd deleted the FLINK-12539 branch May 24, 2019 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants