[legal] Updates LICENSE/NOTICE file of source and binary distribution #830
Conversation
| - Apache Commons Math (org.apache.commons:commons-math:2.2 - http:https://commons.apache.org/proper/commons-math/) | ||
| - Apache Commons Compress (org.apache.commons:commons-compress:1.4.1 - http:https://commons.apache.org/proper/commons-compress/) | ||
| - Apache log4j (log4j:log4j:1.2.17 - http:https://logging.apache.org/log4j/1.2/) | ||
| - Apache Avro (org.apache.avro:avro:1.7.6 - http:https://avro.apache.org) | ||
| - Apache Hadoop (http:https://hadoop.apache.org) |
There was a problem hiding this comment.
Technically, we don't include Hadoop any more in our binary distribution. The reason is, because it is contained in org.apache.flink:flink-shaded-include-yarn which contains the shaded Hadoop dependencies. Thus, what we actually have to include here is the org.apache.flink:flink-shaded-include-yarn dependency and add its NOTICE file to the NOTICE file of the binary distribution.
|
Did a pass and other than small comments, LGTM +1 |
| @@ -218,13 +218,9 @@ conditions of their respective licenses. | |||
| The Apache Flink project bundles the following files under the MIT License: | |||
|
|
|||
| - jQuery v2.1.0. (http:https://jquery.com) - Copyright 2014 jQuery Foundation and other contributors | |||
| - jQuery resize event v1.1 (http:https://benalman.com/projects/jquery-resize-plugin/) - Copyright (c) 2010 "Cowboy" Ben Alman | |||
There was a problem hiding this comment.
I think the here deleted lines are "transitively" includes, because their contents has been copied into one of the other files we include (by that files' authors). I therefore added them, because I was under the impression that those files were actually not respecting the license conditions properly, and that we should mention these dependencies to be correct.
There was a problem hiding this comment.
tl:dr - I think we should keep these entries, actually.
There was a problem hiding this comment.
Do you know which files include the jquery resize event?
There was a problem hiding this comment.
I'm not a JavaScript expert but I can neither find parts of Ben's non-minified code [1] nor parts of the minified code [2] in our repository. But maybe we're using a different version somewhere.
[1] https://raw.githubusercontent.com/cowboy/jquery-resize/v1.1/jquery.ba-resize.js
[2] https://raw.githubusercontent.com/cowboy/jquery-resize/v1.1/jquery.ba-resize.min.js
|
If there are no objections, I'd like to merge it this evening. Then we can create the next release candidate. |
* [MATRIX-97] Always retry on quota errors up to maxRetries value. Don't reduce the number of retries just because the service gave a retry-after value, as requests from multiple threads (or other callers) will contend for the quota.
I went through the dependencies of our source and binary distribution and updated the corresponding LICENSE/NOTICE files. I would appreciate if a second pair of eyes could verify my changes.