[FLINK-12170] [table-planner-blink] Add support for generating optimized logical plan for Over aggregate #8157
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
| Expression[] orderKeyEquals = new Expression[orderKeyTypes.length]; | ||
| for (int i = 0; i < orderKeyTypes.length; ++i) { | ||
| Expression lasValue = lastValues[i]; | ||
| // if (lastValue is null) { |
There was a problem hiding this comment.
These are comments, just look like code. I have deleted them.
There was a problem hiding this comment.
Sorry, my bad, i think it makes sense to keep this as comment, it can help us understand the logic
There was a problem hiding this comment.
I have reverted them
|
|
||
| @Override | ||
| public int operandCount() { | ||
| return 1; |
Sorry, I forget to move the test result xml files to table/plan/batch/sql/agg path after I move HashAggregateTest and SortAggregateTest from table.plan.batch.sql package to table.plan.batch.sql.agg package. |
…zed logical plan for Over aggregate
…zed logical plan for Over aggregate (apache#8157)
What is the purpose of the change
Add support for generating optimized logical plan for Over aggregate
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation