Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-12120][table-planner-blink] Support e2e SortAggregate and HashAggregate operator run in batch mode #8120

Merged
merged 1 commit into from
Apr 12, 2019

Conversation

JingsongLi
Copy link
Contributor

What is the purpose of the change

Introduce "select sum(b), count(c) from T group by a" in Blink batch
Finish batch sort agg and batch hash agg.

Brief change log

  • Finish BatchExecSortAggregate
  • Finish BatchExecHashAggregate
  • Add AggITCase
  • Add hash exchange to BatchExecExchange
  • Finish BatchExecSort
  • Fix DecimalAvgAggFunction bug
  • Fix agg resultType not use scala implicitly type in AggCodeGenHelper
  • Add row type support in CodeGenUtils.hashCodeForType
  • Fix setDecimal in CodeGenUtils
  • Invoke endInput in close before the introducing of runtime

Verifying this change

ut

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (JavaDocs)

@JingsongLi JingsongLi changed the title [FLINK-12120][table-planner-blink] Introduce "select sum(b), count(c) from T group by a" in Blink batch [FLINK-12120][table-planner-blink] Support queries like "select sum(b), count(c) from T group by a" run in batch mode Apr 8, 2019
@flinkbot
Copy link
Collaborator

flinkbot commented Apr 8, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@KurtYoung
Copy link
Contributor

update the title?

@JingsongLi JingsongLi changed the title [FLINK-12120][table-planner-blink] Support queries like "select sum(b), count(c) from T group by a" run in batch mode [FLINK-12120][table-planner-blink] Support e2e SortAggregate and HashAggregate operator run in batch mode Apr 11, 2019
@KurtYoung KurtYoung merged commit 76841be into apache:master Apr 12, 2019
HuangZhenQiu pushed a commit to HuangZhenQiu/flink that referenced this pull request Apr 22, 2019
tianchen92 pushed a commit to tianchen92/flink that referenced this pull request May 13, 2019
@JingsongLi JingsongLi deleted the aggIt branch June 11, 2019 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants