Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-11834] [table-planner-blink] Introduce flink logical relational nodes #7910

Merged
merged 5 commits into from
Mar 7, 2019

Conversation

godfreyhe
Copy link
Contributor

@godfreyhe godfreyhe commented Mar 6, 2019

What is the purpose of the change

Introduce flink logical relational nodes.
This commit includes most flink logical relational nodes, the rest will be introduced by other commit.

Brief change log

  • Adds nodes extended from Calcite, including FlinkLogicalAggregate, FlinkLogicalCalc, FlinkLogicalCorrelate, FlinkLogicalIntersect, FlinkLogicalJoin, FlinkLogicalMinus, FlinkLogicalOverWindow, FlinkLogicalSort, FlinkLogicalUnion, FlinkLogicalValues, FlinkLogicalTableSourceScan, FlinkLogicalTableFunctionScan
  • Adds new RelNode for Flink, including Expand, Rank, Sink, WatermarkAssigner

Verifying this change

This change is an initialization work without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (not documented)

…l nodes

This commit includes most flink logical relational nodes, the rest will be introduced by other commit.
@flinkbot
Copy link
Collaborator

flinkbot commented Mar 6, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

Copy link
Contributor

@KurtYoung KurtYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i only have one minor comment

*/
package org.apache.flink.table.plan.util

sealed trait RankRange extends Serializable {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is a part of your Rank rel node, i think should not belong to util

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RankRange can be moved into Rank.scala file

@godfreyhe
Copy link
Contributor Author

FlinkLogicalTableSourceScan is also added into this commit. The rest flink logical nodes(contains: FlinkLogicalWindowAggregate, FlinkLogicalSnapshot, FlinkLogicalSemiJoin, FlinkLogicalMatch ) will be introduced later because they depend on Expression or Calcite change.

@KurtYoung
Copy link
Contributor

I think you can open a jira to track all unmerged logical nodes

@KurtYoung KurtYoung merged commit fd04309 into apache:master Mar 7, 2019
HuangZhenQiu pushed a commit to HuangZhenQiu/flink that referenced this pull request Apr 22, 2019
…l nodes (apache#7910)

* [FLINK-11834] [table-planner-blink] Introduce flink logical relational nodes

This commit includes most flink logical relational nodes, the rest will be introduced by other commit.

* add FlinkLogicalTableFunctionScan
* add FlinkLogicalTableSourceScan
* move RankRange into Rank.scala file
@godfreyhe godfreyhe deleted the FLINK-11834 branch June 1, 2019 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants